Add broadcast for stream open in process_stream_chunk#308
Open
TheRealNeil wants to merge 1 commit intoactiveagents:mainfrom
Open
Add broadcast for stream open in process_stream_chunk#308TheRealNeil wants to merge 1 commit intoactiveagents:mainfrom
TheRealNeil wants to merge 1 commit intoactiveagents:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #289
Summary
Add broadcast_stream_open call in OpenAI::ChatProvider#process_stream_chunk to establish the streaming lifecycle
Root cause
The OpenAI ChatProvider#process_stream_chunk never called broadcast_stream_open, so the streaming flag was never set to true. When streaming finished, broadcast_stream_close checked return unless streaming and returned early — meaning on_stream_close callbacks never fired. This affected both OpenAI and Ollama (which inherits from the OpenAI provider).
The Anthropic and mock providers already called broadcast_stream_open correctly; the OpenAI provider was the odd one out.
Fix
Add broadcast_stream_open at the top of process_stream_chunk, mirroring the pattern in the Anthropic and mock providers. This ensures the full stream lifecycle (open → update → close) fires correctly.
Test plan