Fix attribute type errors for LEVELS.#70
Merged
FoamyGuy merged 2 commits intoadafruit:mainfrom Feb 25, 2026
Merged
Conversation
alec-bike
force-pushed
the
fix-levels-type-error
branch
3 times, most recently
from
d4a5ea6 to
4db61d3
Compare
alec-bike
force-pushed
the
fix-levels-type-error
branch
from
4db61d3 to
6c4f1d9
Compare
Contributor
Author
|
I also updated some type annotations to fix ty warnings. I still see |
Contributor
Author
|
I tested this branch on a Feather M4 Express with my logging code and it worked as expected. @FoamyGuy this PR is ready for review. |
FoamyGuy
approved these changes
Feb 25, 2026
Contributor
FoamyGuy
left a comment
FoamyGuy
left a comment
There was a problem hiding this comment.
Looks good to me, thank you!
I did a quick smoke test with simpletest and filehandler test on a Fruit Jam, all is working as expected.
adafruit-adabot
pushed a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Feb 26, 2026
Updating https://github.com/adafruit/Adafruit_CircuitPython_Logging to 5.6.1 from 5.6.0: > Merge pull request adafruit/Adafruit_CircuitPython_Logging#70 from alec-bike/fix-levels-type-error
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using
logging.INFOthrows a type check error when using ty (astral-sh/ty#2868).This PR explicitly declares the
LEVELSglobals to avoid the type checker error. Fixes: #69.