Skip to content

Update: JSDoc documentation for drawer system (fixes #812)#813

Merged
oliverfoster merged 5 commits intomasterfrom
issue/812
Apr 13, 2026
Merged

Update: JSDoc documentation for drawer system (fixes #812)#813
oliverfoster merged 5 commits intomasterfrom
issue/812

Conversation

@joe-replin
Copy link
Copy Markdown
Contributor

Fix

Update

Added comprehensive JSDoc documentation to the drawer system (3 files):

  • drawer.js - Singleton service documentation with complete API reference

    • File/module headers with architecture overview
    • Public events section listing all triggered events
    • All public API methods documented: isOpen, open(), openCustomView(), addItem(), hasItem(), close(), toggle(), remove()
    • Usage examples for menu item registration and custom view patterns
    • Known Issues section documenting DrawerCollection accessibility and missing update methods
  • drawerView.js - Main controller view documentation

    • File/module headers explaining dual-mode operation (menu/custom view)
    • Configuration options and position logic documented
    • Public events section
    • Key methods documented: setDrawerPosition(), openCustomView(), showDrawer(), hideDrawer(), remove()
    • Known Issues section identifying single-item toggle workaround, force close hack, and tight coupling to navigation
    • Skipped Backbone config methods per JSDoc style guide
  • drawerItemView.js - Menu item view documentation

    • File/module headers with lifecycle and model structure
    • Class documentation with usage notes
    • onDrawerItemClicked() method documented with callback pattern example
    • Noted internal creation pattern (not for direct instantiation)

All documentation follows the established JSDoc style guide patterns established in the notify system work.

Testing

  1. JSDoc generates correctly for all three files
  2. Cross-references ({@link}) resolve properly
  3. Examples are syntactically valid
  4. No JSDoc syntax errors or warnings

Copy link
Copy Markdown
Member

@oliverfoster oliverfoster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really good.

Comment thread js/drawer.js Outdated
Comment thread js/drawer.js Outdated
@oliverfoster
Copy link
Copy Markdown
Member

Can you remove the "Improvements" and "Known Issues" sections, please? We can do those as separate issues after a further analysis phase.

@joe-replin
Copy link
Copy Markdown
Contributor Author

Can do. Everything has been updated and ready for another review.

@joe-replin joe-replin linked an issue Feb 4, 2026 that may be closed by this pull request
12 tasks
@oliverfoster
Copy link
Copy Markdown
Member

Could you add a description of what the drawer is, please?

Something like, but not:
"A sidebar container for plugin launch buttons. Once a plugin launch button is clicked, the sidebar view displays the plugin's custom view inside the drawer. The custom view has a back button to return to the plugin launch buttons."

@joe-replin
Copy link
Copy Markdown
Contributor Author

joe-replin commented Feb 9, 2026

Could you add a description of what the drawer is, please?

Something like, but not: "A sidebar container for plugin launch buttons. Once a plugin launch button is clicked, the sidebar view displays the plugin's custom view inside the drawer. The custom view has a back button to return to the plugin launch buttons."

Added to the top-level class description.

Copy link
Copy Markdown
Contributor

@swashbuck swashbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit 40e5aaf into master Apr 13, 2026
@oliverfoster oliverfoster deleted the issue/812 branch April 13, 2026 10:08
@github-project-automation github-project-automation Bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Apr 13, 2026
github-actions Bot pushed a commit that referenced this pull request Apr 13, 2026
# [6.76.0](v6.75.2...v6.76.0) (2026-04-13)

### Fix

* Logic for detecting removed elements (fixed #819) (#820) ([7a21597](7a21597)), closes [#819](#819) [#820](#820)

### Update

* JSDoc documentation for drawer system (fixes #812) (#813) ([40e5aaf](40e5aaf)), closes [#812](#812) [#813](#813)
* JSDoc documentation for notification system (fixes #810) (#811) ([7d97a8c](7d97a8c)), closes [#810](#810) [#811](#811)
@oliverfoster
Copy link
Copy Markdown
Member

🎉 This PR is included in version 6.76.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Recently Released

Development

Successfully merging this pull request may close these issues.

JSDocs - Drawer Add JSDoc Documentation to Core Framework

3 participants