feat: export PricingOption and other union type aliases from main package#121
Merged
feat: export PricingOption and other union type aliases from main package#121
Conversation
…kage Export PricingOption, Deployment, Destination, and PublisherProperties union type aliases from the main adcp package. These unions fix mypy list-item errors when constructing objects like Product.pricing_options. The PricingOption union combines all pricing variants (CpmPricingOption, VcpmPricingOption, CpcPricingOption, etc.) into a single type that mypy recognizes, avoiding the RootModel wrapper issues. Closes #120 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PricingOption,Deployment,Destination, andPublisherPropertiesunion type aliases from the mainadcppackagePricingOptionunion combines all pricing option variants (CpmPricingOption, VcpmPricingOption, etc.) into a single type that mypy recognizesProduct.pricing_optionsTest plan
--strictCloses #120
🤖 Generated with Claude Code