feat: add detailed protocol logging for MCP and A2A requests#151
Open
EmmaLouise2018 wants to merge 3 commits intomainfrom
Open
feat: add detailed protocol logging for MCP and A2A requests#151EmmaLouise2018 wants to merge 3 commits intomainfrom
EmmaLouise2018 wants to merge 3 commits intomainfrom
Conversation
2ee3636 to
97d5b35
Compare
Contributor
|
why did this reformat every single file? it's ok but hard to see what changed. did you update the testing UI to use this for debug? |
fd514bd to
de0f954
Compare
Add configurable wire-level logging to capture exact HTTP
requests and responses for both MCP and A2A protocols.
Features:
- Log exact request/response payloads, headers, and timing
- Configurable granularity (requests, responses, bodies)
- Auth header redaction for security (enabled by default)
- Body size limits to prevent log spam
- Latency tracking for performance monitoring
Configuration example:
protocolLogging: {
enabled: true,
logRequests: true,
logResponses: true,
logRequestBodies: true,
logResponseBodies: true,
maxBodySize: 50000,
redactAuthHeaders: true
}
Use cases: debugging, monitoring, troubleshooting
Files: ADCPClient.ts, TaskExecutor.ts, mcp.ts, a2a.ts,
protocols/index.ts
Performance impact: ~3-7ms per request with full logging
- Add protocol logging checkbox to testing UI - Add /api/sales/agents/:agentId/query endpoint with protocol logging support - Export ProtocolLoggingConfig type from library - Wire-level HTTP logs now display in debug panel when enabled
cd9f60e to
134852e
Compare
Contributor
Author
Addressed feedback:
How to test:
|
Contributor
|
@EmmaLouise2018 can we close? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds comprehensive wire-level logging for both MCP and A2A protocol requests. This allows debugging of exact HTTP requests/responses being sent over the network.
Changes
protocolLoggingconfiguration toADCPClientConfigConfiguration Options
Documentation
docs/PROTOCOL-LOGGING.mdwith comprehensive guideexamples/protocol-logging.tswith 9 usage examplestest-protocol-logging.tsfor testingTesting
Fixes request for detailed wire-level protocol logging.