fix: brand identity bugs — has_manifest, logo resolution, and setup link#1198
Merged
fix: brand identity bugs — has_manifest, logo resolution, and setup link#1198
Conversation
- Fix resolve_brand MCP tool returning has_manifest: false when brand.json is found (source === 'brand_json' is the correct condition) - Fix discovered brand logo not showing: resolveBrand() now reads logos from brands[0].logos (house_portfolio structure) before falling back to top-level - Fix 'Set up brand' link redirecting to dashboard for existing org members; /onboarding?step=brand now shows the brand setup form with org name and email domain pre-filled - Fix migration 250 view recreation failure (DROP before CREATE) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
resolve_brandMCP tool returnedhas_manifest: falseeven when brand.json was found — the check was!!resolved.brand_manifest(object presence) butbrand_manifestisn't populated forbrand_agentand somehouse_portfoliovariants. Fixed toresolved.source === 'brand_json'which is the authoritative signal.resolveBrand()was readingmanifest.logosdirectly, but house_portfolio brand.json stores logos inbrands[0].logos. Fixed to checkbrands[0]structure first, falling back to top-level./dashboardfor existing org members.onboarding.htmlnow handles?step=brandby showing the brand setup form with org name and email domain pre-filled.Test plan
/onboarding?step=brandshows brand setup form for existing org member (not redirected)/onboarding?step=brand🤖 Generated with Claude Code
Mintlify
0 threads from 0 users in Mintlify