removed locking from Adjust singleton creation#404
Open
toby78 wants to merge 4 commits intoadjust:masterfrom
Open
removed locking from Adjust singleton creation#404toby78 wants to merge 4 commits intoadjust:masterfrom
toby78 wants to merge 4 commits intoadjust:masterfrom
Conversation
… a time - so every other thread will need to wait.
… a time - so every other thread will need to wait.
… a time - so every other thread will need to wait - increased version to 4.19.1
Member
|
While I agree that removing the private volatile AdjustInstance defaultInstance;
public static void AdjustInstance getDefaultInstance()
{
if (defaultInstance == null) {
synchronized (Adjust.class) {
if (defaultInstance == null) {
defaultInstance = new AdjustInstance();
}
}
}
return defaultInstance;
} |
…t a time - so every other thread will need to wait - increased version to 4.19.1
Author
|
PR updated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removed locking from Adjust singleton creation. Create instance immediately when the class is loaded or initialized (Android ClassLoader). It will be 100% thread safe and the object instance will already be available before any thread accesses it. If class should not be created, disable the SDK instead.