Function corrected#1
Open
PatrickImProVision wants to merge 5 commits intoadmiyn:masterfrom
PatrickImProVision:patch-1
Open
Function corrected#1PatrickImProVision wants to merge 5 commits intoadmiyn:masterfrom PatrickImProVision:patch-1
PatrickImProVision wants to merge 5 commits intoadmiyn:masterfrom
PatrickImProVision:patch-1
Conversation
added 5 commits
November 24, 2014 04:23
Correction made in : line 11 : if($code_array[$i] == "Z") changed to if($code_array[$i] == end($chars)) line 23 : if($code_array[$i -1] != 'Z') changed to if($code_array[$i -1] != end($chars)) line 32 : $code_array[$j] = 0; changed to $code_array[$j] = reset($chars); Because it detect last and first character/value in array The generation was wrong. For example when it should generate string BA, the function generated B0 instead. Anyway the function is now working correctly.
I have put more option to choose from key types.
Sequential Alphanumeric Generator changed to Unique Sequential Alphanumeric Generator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correction made in :
line 11 :
if($code_array[$i] == "Z")
changed to
if($code_array[$i] == end($chars))
line 23 :
if($code_array[$i -1] != 'Z')
changed to
if($code_array[$i -1] != end($chars))
line 32 :
$code_array[$j] = 0;
changed to
$code_array[$j] = reset($chars);
Because it detect last and first character/value in array
The generation was wrong.
For example when it should generate string BA, the function generated B0 instead.
Anyway the function is now working correctly.