Skip to content

fix: remove node-fetch, use built-in fetch#31

Closed
shazron wants to merge 1 commit intomasterfrom
fetch-update
Closed

fix: remove node-fetch, use built-in fetch#31
shazron wants to merge 1 commit intomasterfrom
fetch-update

Conversation

@shazron
Copy link
Member

@shazron shazron commented Jan 21, 2025

Motivation and Context

node-fetch@v2's dependencies use the built in punycode module, which is deprecated in node-22, and prints out a deprecation warning.

How Has This Been Tested?

  • npm test

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@codecov
Copy link

codecov bot commented Jan 21, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@shazron
Copy link
Member Author

shazron commented Nov 12, 2025

obsolete in favor of #32

@shazron shazron closed this Nov 12, 2025
@shazron shazron deleted the fetch-update branch November 12, 2025 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant