Skip to content

fix(auth): make user identifier comparison case-insensitive #246

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bosschaert merged 1 commit into from
Feb 25, 2026
Merged

fix(auth): make user identifier comparison case-insensitive #246

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/utils/auth.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,7 +186,7 @@ function getIdents(user) {
}
}

return idents;
return idents.map((ident) => ident?.toLowerCase());
}

export function getUserActions(pathLookup, user, target) {
Expand Down Expand Up @@ -273,7 +273,8 @@ export async function getAclCtx(env, org, users, key, api) {
effectivePath = effectivePath.slice(0, -1);
}

groups.split(',').map((entry) => entry.trim()).filter((entry) => entry.length > 0).forEach((group) => {
groups.split(',').map((entry) => entry.trim()).filter((entry) => entry.length > 0).forEach((g) => {
const group = g.toLowerCase();
if (!pathLookup.has(group)) pathLookup.set(group, []);
const groupEntries = pathLookup.get(group);
const effectiveActions = actions
Expand Down Expand Up @@ -322,7 +323,9 @@ export async function getAclCtx(env, org, users, key, api) {
}

// Expose the action trace or not?
actionTrace = users.every((u) => aclTrace.includes(u.email)) ? actionTrace : undefined;
actionTrace = users.every((u) => aclTrace.includes(u.email?.toLowerCase()))
? actionTrace
: undefined;

if (k === 'CONFIG' || api === 'versionsource') {
actionSet.add('read');
Expand Down
141 changes: 113 additions & 28 deletions test/utils/auth.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,12 +130,12 @@ describe('DA auth', () => {
data: [
{
path: '/x',
groups: '2345B0EA551D747/4711,123,joe@bloggs.org',
groups: '2345B0EA551D747/4711,123,joe@bloggs.org,MEL@bloggs.org',
actions: 'write',
},
{
path: '/**',
groups: '2345B0EA551D747/4711,123,joe@bloggs.org',
groups: '2345B0EA551D747/4711,123,joe@bloggs.org,MEL@bloggs.org',
actions: 'read',
},
{
Expand Down Expand Up @@ -173,9 +173,14 @@ describe('DA auth', () => {
groups: '2345B0EA551D747/4711',
actions: 'write',
},
{
path: '/tar/abc',
groups: '2345B0ea551D747/4711',
actions: 'write',
},
{
path: 'ACLTRACE',
groups: 'joe@bloggs.org',
groups: 'joe@bloggs.org,MEL@bloggs.org',
actions: 'read',
},
{
Expand All @@ -198,14 +203,14 @@ describe('DA auth', () => {
it('test path sorting', async () => {
const users = [{ groups: [{ orgIdent: '2345B0EA551D747', groupName: 4711 }] }];
const aclCtx = await getAclCtx(env2, 'test', users, '/mykey');
const paths = aclCtx.pathLookup.get('2345B0EA551D747/4711').map((x) => x.path);

assert.strictEqual(8, paths.length);
assert.strictEqual('/bar/q', paths[0], 'q should be counted as shorter than +**');
assert.strictEqual('/bar/+**', paths[1], 'bar/+** should be longer than bar/');
assert(paths[3] === '/bar' || paths[4] === '/bar', 'Within the same length there is no order');
assert.strictEqual('/x', paths[5]);
assert(paths[6] === '/**' || paths[7] === '/**', '/** should be counted as longer than /x');
const paths = aclCtx.pathLookup.get('2345b0ea551d747/4711').map((x) => x.path);

assert.strictEqual(9, paths.length);
assert.strictEqual('/bar/q', paths[1], 'q should be counted as longer than +**');
assert.strictEqual('/bar/+**', paths[2], 'bar/+** should be longer than bar/');
assert(paths[4] === '/bar' || paths[5] === '/bar', 'Within the same length there is no order');
assert.strictEqual('/x', paths[6]);
assert(paths[7] === '/**' || paths[8] === '/**', '/** should be counted as shorter than /x');
});

it('test hasPermission returns false when path is null or undefined', async () => {
Expand Down Expand Up @@ -289,6 +294,30 @@ describe('DA auth', () => {
}, 'test', 'read'));
});

it('test hasPermissions2a', async () => {
const users = [{ orgs: [{ orgIdent: '2345B0ea551D747', groups: [{ groupName: '8080' }] }] }];
const aclCtx = await getAclCtx(env2, 'test', users, '/test');

assert(hasPermission({
users, org: 'test', key: '/test', aclCtx,
}, '/test', 'write'));
assert(hasPermission({
users, org: 'test', key: '/test', aclCtx,
}, '/test', 'read'));
});

it('test hasPermissions2b', async () => {
const users = [{ orgs: [{ orgIdent: '2345B0EA551D747', groups: [{ groupName: '8080' }] }] }];
const aclCtx = await getAclCtx(env2, 'test', users, '/test');

assert(hasPermission({
users, org: 'test', key: '/test', aclCtx,
}, '/tar/abc', 'write'));
assert(hasPermission({
users, org: 'test', key: '/test', aclCtx,
}, '/tar/abc', 'read'));
});

it('test hasPermissions3', async () => {
const key = '/test';
const users = [{ orgs: [{ orgIdent: '2345B0EA551D747', groups: [{ groupName: '4711' }, { groupName: '8080' }] }] }];
Expand Down Expand Up @@ -343,6 +372,54 @@ describe('DA auth', () => {
}, '/test', 'write'));
});

it('test hasPermissions7', async () => {
const users = [{ email: 'JOE@BLOGGS.ORG', orgs: [] }];
const aclCtx = await getAclCtx(env2, 'test', users, '/test');

assert(hasPermission({
users, org: 'test', aclCtx, key: '',
}, '/test', 'read'));
assert(!hasPermission({
users, org: 'test', aclCtx, key: '',
}, '/test', 'write'));
assert(hasPermission({
users, org: 'test', aclCtx, key: '/test',
}, '/test', 'read'));
assert(!hasPermission({
users, org: 'test', aclCtx, key: '/test',
}, '/test', 'write'));
assert(hasPermission({
users, org: 'test', aclCtx, key: '/test',
}, '/x', 'read'));
assert(hasPermission({
users, org: 'test', aclCtx, key: '/test',
}, '/x', 'write'));
});

it('test hasPermissions8', async () => {
const users = [{ email: 'mel@bloggs.org', orgs: [] }];
const aclCtx = await getAclCtx(env2, 'test', users, '/test');

assert(hasPermission({
users, org: 'test', aclCtx, key: '',
}, '/test', 'read'));
assert(!hasPermission({
users, org: 'test', aclCtx, key: '',
}, '/test', 'write'));
assert(hasPermission({
users, org: 'test', aclCtx, key: '/test',
}, '/test', 'read'));
assert(!hasPermission({
users, org: 'test', aclCtx, key: '/test',
}, '/test', 'write'));
assert(hasPermission({
users, org: 'test', aclCtx, key: '/test',
}, '/x', 'read'));
assert(hasPermission({
users, org: 'test', aclCtx, key: '/test',
}, '/x', 'write'));
});

it('test trace information', async () => {
const users = [{ email: 'joe@bloggs.org', orgs: [{ orgIdent: '2345B0EA551D747', groups: [{ groupName: '4711' }] }] }];
const aclCtx = await getAclCtx(env2, 'test', users, '/bar/blah.html');
Expand All @@ -353,12 +430,20 @@ describe('DA auth', () => {
const groupTraceIdx = 1 - emailTraceIdx;
assert.deepStrictEqual({ group: 'joe@bloggs.org', path: '/**', actions: ['read'] }, trace[emailTraceIdx]);
assert.deepStrictEqual({
group: '2345B0EA551D747/4711',
group: '2345b0ea551d747/4711',
path: '/bar/+**',
actions: ['read', 'write'],
}, trace[groupTraceIdx]);
});

it('test trace information2', async () => {
const users = [{ email: 'MEL@BLOGGS.ORG', orgs: [{ orgIdent: 'abcd', groups: [{ groupName: '1234' }] }] }];
const aclCtx = await getAclCtx(env2, 'test', users, '/bar/blah.html');
const trace = aclCtx.actionTrace;

assert.deepStrictEqual([{ group: 'mel@bloggs.org', path: '/**', actions: ['read'] }], trace);
});

it('test CONFIG api', async () => {
const users = [{ orgs: [{ orgIdent: '123' }] }];
const aclCtx = await getAclCtx(env2, 'test', users, '/', 'config');
Expand Down Expand Up @@ -752,7 +837,7 @@ describe('DA auth', () => {
{ path: '/da-aem-boilerplate/authtest/**', actions: ['read', 'write'] },
{ path: '/**', actions: [] },
];
pathlookup.set('ABCDEFG/grp1', patharr2);
pathlookup.set('abcdefg/grp1', patharr2);

const user = {
email: 'joe@acme.com',
Expand Down Expand Up @@ -838,16 +923,16 @@ describe('DA auth', () => {
}],
};
const pathLookup = new Map();
pathLookup.set('ABCDEFG', [{ ident: 'ABCDEFG', path: '/xyz', actions: ['read'] }]);
pathLookup.set('ABCDEFG/grp1', [{ ident: 'ABCDEFG/grp1', path: '/xyz', actions: ['read'] }]);
pathLookup.set('ABCDEFG/111', [{ ident: 'ABCDEFG/111', path: '/xyz', actions: ['read'] }]);
pathLookup.set('ABCDEFG/foo@bar.org', [{ ident: 'ABCDEFG/foo@bar.org', path: '/xyz', actions: ['read'] }]);
pathLookup.set('abcdefg', [{ ident: 'abcdefg', path: '/xyz', actions: ['read'] }]);
pathLookup.set('abcdefg/grp1', [{ ident: 'abcdefg/grp1', path: '/xyz', actions: ['read'] }]);
pathLookup.set('abcdefg/111', [{ ident: 'abcdefg/111', path: '/xyz', actions: ['read'] }]);
pathLookup.set('abcdefg/foo@bar.org', [{ ident: 'abcdefg/foo@bar.org', path: '/xyz', actions: ['read'] }]);
pathLookup.set('org1/grp1', [{ ident: 'org1/grp1', path: '/xyz', actions: ['read'] }]);
pathLookup.set('org1/111', [{ ident: 'org1/111', path: '/xyz', actions: ['read'] }]);
pathLookup.set('HIJKLMN', [{ ident: 'HIJKLMN', path: '/xyz', actions: ['read'] }]);
pathLookup.set('HIJKLMN/grp2', [{ ident: 'HIJKLMN/grp2', path: '/xyz', actions: ['read'] }]);
pathLookup.set('HIJKLMN/222', [{ ident: 'HIJKLMN/222', path: '/xyz', actions: ['read'] }]);
pathLookup.set('HIJKLMN/foo@bar.org', [{ ident: 'HIJKLMN/foo@bar.org', path: '/xyz', actions: ['read'] }]);
pathLookup.set('hijklmn', [{ ident: 'hijklmn', path: '/xyz', actions: ['read'] }]);
pathLookup.set('hijklmn/grp2', [{ ident: 'hijklmn/grp2', path: '/xyz', actions: ['read'] }]);
pathLookup.set('hijklmn/222', [{ ident: 'hijklmn/222', path: '/xyz', actions: ['read'] }]);
pathLookup.set('hijklmn/foo@bar.org', [{ ident: 'hijklmn/foo@bar.org', path: '/xyz', actions: ['read'] }]);
pathLookup.set('org2/grp2', [{ ident: 'org2/grp2', path: '/xyz', actions: ['read'] }]);
pathLookup.set('org2/222', [{ ident: 'org2/222', path: '/xyz', actions: ['read'] }]);
pathLookup.set('foo@bar.org', [{ ident: 'foo@bar.org', path: '/xyz', actions: ['read'] }]);
Expand All @@ -856,12 +941,12 @@ describe('DA auth', () => {

const matchedIds = res.trace.map((r) => r.ident);
assert.strictEqual(7, matchedIds.length);
assert(matchedIds.includes('ABCDEFG'));
assert(matchedIds.includes('ABCDEFG/grp1'));
assert(matchedIds.includes('ABCDEFG/foo@bar.org'));
assert(matchedIds.includes('HIJKLMN'));
assert(matchedIds.includes('HIJKLMN/grp2'));
assert(matchedIds.includes('HIJKLMN/foo@bar.org'));
assert(matchedIds.includes('abcdefg'));
assert(matchedIds.includes('abcdefg/grp1'));
assert(matchedIds.includes('abcdefg/foo@bar.org'));
assert(matchedIds.includes('hijklmn'));
assert(matchedIds.includes('hijklmn/grp2'));
assert(matchedIds.includes('hijklmn/foo@bar.org'));
assert(matchedIds.includes('foo@bar.org'));
});

Expand All @@ -877,7 +962,7 @@ describe('DA auth', () => {
{ path: '/blah/hoho/hihi', actions: ['read'] },
{ path: '/hello/+**', actions: ['read', 'write'] },
]);
pathLookup.set('ABCDEF', [
pathLookup.set('abcdef', [
{ path: '/blah/hohoho', actions: ['read'] },
{ path: '/blah/+**', actions: ['read'] },
{ path: '/hello/+**', actions: ['read'] },
Expand Down
Loading