Conversation
LCOV of commit
|
Contributor
|
The changes look good to me. I see a number of failing unit tests - so I guess this is still work-in-progress 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Workers binding is pretty cool because it makes code simple and is easy to use.
But... DurableObject is not fully stable on the CloudFlare side (see the recommended error handling with 3 retries... https://developers.cloudflare.com/durable-objects/best-practices/error-handling/).
Also, each object (da-collab worker, da-admin worker, the DurableObject) has its own lifecycle in memory and we can observe random internal errors when using those workers.
To not rely on those bindings, a simple solution is to make a simple fetch on the da-admin endpoint.
This is also a got first step to a da-admin migration on a different infra.