feat: add @adobe/spacecat-shared-drs-client package (LLMO-1819)

[dzehnder]

Summary

• New shared package @adobe/spacecat-shared-drs-client providing an HTTP client for the Data Retrieval Service (DRS) API
• Enables both spacecat-api-service and spacecat-audit-worker to interact with DRS for prompt generation and brand presence re-analysis
• Methods: createFrom(), isConfigured(), submitJob(), submitPromptGenerationJob(), triggerBrandDetection(), getJob()
• 17 unit tests, 100% coverage

Context

As part of the migration from Mystique to DRS for brand presence execution, both api-service (onboarding) and audit-worker (config-change triggers) need to call DRS. The client was previously a local file in api-service only.

Dependent PRs

• spacecat-api-service: Migrates from local drs-client.js to this shared package
• spacecat-audit-worker: Uses this package to replace Mystique brand presence triggers with DRS calls

Test plan

• 17 unit tests with nock HTTP mocking
• 100% line, branch, function, and statement coverage
• E2E: verify DRS job submission after shared package is published

Made with Cursor

[github-actions]

This PR will trigger a minor release when merged.

[AndreiAlexandruParaschiv]

There's a parallel effort on #1382 that also introduces a DRS client package. The two PR's have different use cases for DRS but create the same package. Maybe the two PRs can find a common ground? @rarescheseli

[dzehnder]

Thanks @AndreiAlexandruParaschiv! I was not aware of that. However @rarescheseli seems off today and I need this right away. So I propose that after I merge, @rarescheseli can add all the other functionalities that is needed afterwards.

[danieljchuser]

PR Review: @adobe/spacecat-shared-drs-client

Overall: Clean, well-structured new package that follows established monorepo patterns. 17 tests with 100% coverage thresholds. A few issues to address:

---

Issues

1. MEDIUM — Missing context caching in createFrom()

src/index.js:26-27 — The BrandClient (and other shared clients) cache the newly created instance back onto context so subsequent calls reuse it:

// BrandClient pattern:
const client = new BrandClient({ apiBaseUrl, apiKey }, log);
context.brandClient = client;   // <-- caches it
return client;

DrsClient checks for a cached instance but never caches a newly created one:

if (context.drsClient) return context.drsClient;
return new DrsClient({ apiBaseUrl, apiKey }, log);  // not cached

This means every call to createFrom() creates a new instance unless the caller pre-populates context.drsClient manually. Suggest adding context.drsClient = client; before returning, consistent with BrandClient.

2. LOW — CodeQL polynomial regex alert still active

src/index.js:31 — The second commit says it "guards regex against null apiBaseUrl to resolve CodeQL polynomial regex alert", but both CodeQL bot comments are still present. The regex /\/+$/ is technically fine (not truly polynomial), but CodeQL flags it. A non-regex alternative would silence it:

let url = apiBaseUrl || '';
while (url.endsWith('/')) url = url.slice(0, -1);
this.apiBaseUrl = url || undefined;

Or simply mark it as a false positive in CodeQL if the team prefers.

3. LOW — model: 'gpt-5-nano' hardcoded

src/index.js:117 — The model name is hardcoded in submitPromptGenerationJob. If DRS supports different models, this should probably be a parameter (with a default). If it's intentionally fixed, a comment explaining why would help future readers.

4. LOW — TypeScript declaration inconsistency

src/index.d.ts:44 — triggerBrandDetection returns Promise<unknown> while other methods return typed results (Promise<DrsJobResult>, Promise<Record<string, unknown>>). Consider Promise<Record<string, unknown>> or a dedicated interface for consistency.

5. NITS

• package.json — Missing bugs and homepage fields that other packages (e.g. brand-client) include. Very minor but keeps things consistent.
• src/index.js:82 — submitJob accesses result.job_id unconditionally in the log. If the response doesn't contain job_id (e.g., unexpected response shape), this would log undefined. A guard or optional chain would be safer.

---

Cross-Repository Impact Assessment

Specialist	Impact	Notes
API (api-service)	LOW — Additive	New dependency to adopt. Dependent PR exists. No breaking changes to existing contracts.
AUDIT (audit-worker)	LOW — Additive	New dependency to adopt. Dependent PR exists. No breaking changes.
INFRA (infrastructure)	NONE	No new queues, buckets, or IAM changes needed. DRS is an external HTTP service.
All others	NONE	Pure addition, no impact on existing packages or contracts.

Positive Notes

• Follows existing monorepo conventions well (.nycrc.json, .releaserc.cjs, .mocha-multi.json, test setup)
• Good use of tracingFetch from spacecat-shared-utils for observability
• Clean separation: generic submitJob for extensibility + specialized submitPromptGenerationJob
• 100% coverage thresholds enforced
• Non-JSON response handling is a nice touch (204 responses)

Verdict

Approve with minor suggestions — The missing context caching (#1) is the most impactful item. The rest are low/nit-level. No breaking changes to any existing cross-repo contracts.

[solaris007]

🎉 This PR is included in version @adobe/spacecat-shared-drs-client-v1.0.0 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀