Skip to content

firefly carousel#877

Closed
suhjainadobe wants to merge 105 commits intostagefrom
doodlebug
Closed

firefly carousel#877
suhjainadobe wants to merge 105 commits intostagefrom
doodlebug

Conversation

@suhjainadobe
Copy link
Copy Markdown
Contributor

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Feb 17, 2026

Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
In case there are problems, just click a checkbox below to rerun the respective action.

  • Re-run PSI checks
  • Re-sync branch
Commits

@aem-code-sync
Copy link
Copy Markdown

aem-code-sync Bot commented Feb 17, 2026

Page Scores Audits Google
📱 /drafts/suhjain/seo-firefly/carousel Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI
🖥️ /drafts/suhjain/seo-firefly/carousel Lighthouse returned error: NOT_HTML. The page provided is not HTML (served as MIME type text/plain). PSI

@suhjainadobe suhjainadobe marked this pull request as draft February 17, 2026 12:04
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 877: firefly carousel due to failing checks

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 877: firefly carousel due to failing checks

1 similar comment
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 877: firefly carousel due to failing checks

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Feb 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.59%. Comparing base (5bec115) to head (cefa413).
⚠️ Report is 23 commits behind head on stage.

Additional details and impacted files
@@            Coverage Diff             @@
##            stage     #877      +/-   ##
==========================================
- Coverage   88.68%   88.59%   -0.10%     
==========================================
  Files          42       42              
  Lines        9146     9248     +102     
==========================================
+ Hits         8111     8193      +82     
- Misses       1035     1055      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

const settle = () => {
if (settled) return;
settled = true;
clearTimeout(fallbackTimer);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-use-before-define> reported by reviewdog 🐶
'fallbackTimer' was used before it was defined.

@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 877: firefly carousel due to failing checks

* Add specificity to upload-marquee css

* review comment

* Revert "review comment"

This reverts commit 09b5e75.

---------

Co-authored-by: vipulg <vipulg@adobe.com>
Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>
@milo-pr-merge-cc
Copy link
Copy Markdown

Skipped merging 877: firefly carousel due to missing verified label. kindly make sure that the PR has been verified

async function buildUploadActionControls(para, columnId, getAriaLabels) {
const buttonLabel = para.textContent.trim().split('|')[0].trim() || 'Upload your image';
const { filePickerAriaSuffix } = await getAriaLabels();
const inputId = buildScopedId('file-upload', columnId);
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'inputId' is assigned a value but never used.

@nkthakur48
Copy link
Copy Markdown
Collaborator

Closing as changes for this have already been pulled in doodlebug branch

@nkthakur48 nkthakur48 closed this Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants