Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
Commits
|
|
|
Skipped merging 877: firefly carousel due to failing checks |
|
Skipped merging 877: firefly carousel due to failing checks |
1 similar comment
|
Skipped merging 877: firefly carousel due to failing checks |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## stage #877 +/- ##
==========================================
- Coverage 88.68% 88.59% -0.10%
==========================================
Files 42 42
Lines 9146 9248 +102
==========================================
+ Hits 8111 8193 +82
- Misses 1035 1055 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| const settle = () => { | ||
| if (settled) return; | ||
| settled = true; | ||
| clearTimeout(fallbackTimer); |
There was a problem hiding this comment.
🚫 [eslint] <no-use-before-define> reported by reviewdog 🐶
'fallbackTimer' was used before it was defined.
|
Skipped merging 877: firefly carousel due to failing checks |
* Add specificity to upload-marquee css * review comment * Revert "review comment" This reverts commit 09b5e75. --------- Co-authored-by: vipulg <vipulg@adobe.com> Co-authored-by: Nishant Thakur <nishant.thakur.ece@gmail.com>
ae6ccb2 to
5793a2d
Compare
|
Skipped merging 877: firefly carousel due to missing verified label. kindly make sure that the PR has been verified |
| async function buildUploadActionControls(para, columnId, getAriaLabels) { | ||
| const buttonLabel = para.textContent.trim().split('|')[0].trim() || 'Upload your image'; | ||
| const { filePickerAriaSuffix } = await getAriaLabels(); | ||
| const inputId = buildScopedId('file-upload', columnId); |
There was a problem hiding this comment.
🚫 [eslint] <no-unused-vars> reported by reviewdog 🐶
'inputId' is assigned a value but never used.
|
Closing as changes for this have already been pulled in |
Resolves: MWPW-NUMBER
Test URLs: