[Draft] [MWPW-179252] Add pageConfig call for optimal endpoint#569
[Draft] [MWPW-179252] Add pageConfig call for optimal endpoint#569
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
| subCode: ActionBinder.ERROR_MAP[errorMetaData.subCode] || errorMetaData.subCode || status, | ||
| desc: errorMetaData.desc || message || info || undefined, | ||
| }, | ||
| logEndPoint: this.acrobatApiConfig?.acrobatEndpoint?.log, |
There was a problem hiding this comment.
slytherin (dc) side changes corresponding to this are in PR:
adobecom/dc#1295
| upload_warn_delete_asset: -603, | ||
| validation_warn_validate_files: -604, | ||
| warn_fetch_experiment: -605, | ||
| warn_page_config_call_failed: -606, |
There was a problem hiding this comment.
check if the dashboard query needs modification to start recording this. Actual modification to be done after the PR merge
There was a problem hiding this comment.
yes, it may need dashboard modifications.
unitylibs/utils/NetworkUtils.js
Outdated
| } | ||
| } | ||
|
|
||
| async checkandUpdatePageConfigEndpoint(updateConfigCallback, onFailure) { |
There was a problem hiding this comment.
| async checkandUpdatePageConfigEndpoint(updateConfigCallback, onFailure) { | |
| async updateUnityEndpoint(updateConfigCallback, onFailure) { |
There was a problem hiding this comment.
updated the name to fetchPageConfig.
The method now accepts unityEndpointSuccessCb and unityEndpointfailureCb and also returns the response body which make it future proof in case more info is being fetched from service in response.
https://jira.corp.adobe.com/browse/MWPW-179252
Corresponding Slytherin PR:
adobecom/dc#1295
Resolves: MWPW-179252
Test URLs: