MWPW-183524 restructure to use common NetworkUtils in workflow-firefly#653
Merged
MWPW-183524 restructure to use common NetworkUtils in workflow-firefly#653
Conversation
vipu0303
requested review from
Ruchika4,
arugupta1992,
rgclayton and
sanjayms01
arugupta1992
requested changes
Jan 5, 2026
| ...(this.id ? { assetId: this.id } : { query: this.query }), | ||
| }; | ||
| const { url } = await this.serviceHandler.postCallToService( | ||
| const postOpts = { |
Collaborator
There was a problem hiding this comment.
Use getApiCallOptions
sanjayms01
reviewed
Jan 12, 2026
| window.lana?.log(`Message: ${msg}, Error: ${error || ''}`, lanaOptions); | ||
| } | ||
| } | ||
| import NetworkUtils from '../../../utils/NetworkUtils.js'; |
Collaborator
There was a problem hiding this comment.
can this be dynamically imported instead?
sanjayms01
approved these changes
Jan 13, 2026
Collaborator
|
sanity checks are done in the given branch for both image, video, sound effect flows |
shasmish
approved these changes
Jan 14, 2026
arugupta1992
approved these changes
Jan 14, 2026
sanjayms01
added a commit
that referenced
this pull request
Jan 14, 2026
- [[MWPW-183524] restructure to use common NetworkUtils in workflow-firefly ](#653) Resolves: [MWPW-183524](https://jira.corp.adobe.com/browse/MWPW-183524) **Test URLs:** - Before: https://main--cc--adobecom.aem.live/products/firefly?unitylibs=stage https://main--cc--adobecom.aem.page/products/firefly/features/sound-effect-generator?unitylibs=stage - After: https://main--cc--adobecom.aem.live/products/firefly?unitylibs=MWPW-183524 https://main--cc--adobecom.aem.page/products/firefly/features/sound-effect-generator?unitylibs=MWPW-183524 Please do a basic validation on firefly workflows around network calls.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code restructuring to use common NetworkUtils in workflow-firefly
Resolves: MWPW-183524
Test URLs:
Before: https://main--cc--adobecom.aem.live/products/firefly?unitylibs=stage
https://main--cc--adobecom.aem.page/products/firefly/features/sound-effect-generator?unitylibs=stage
After: https://main--cc--adobecom.aem.live/products/firefly?unitylibs=MWPW-183524
https://main--cc--adobecom.aem.page/products/firefly/features/sound-effect-generator?unitylibs=MWPW-183524
Please do a basic validation on firefly workflows around network calls.