Merged
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
|
<!-- Before submitting, please review all open PRs. --> * Adding new repo EDGERC secret * Adding Unity workflow CP prod and stage codes Resolves: [MWPW-182131](https://jira.corp.adobe.com/browse/MWPW-182131) **Test URLs:** - Before: https://main--unity--adobecom.aem.page/?martech=off - After: https://MWPW-182131--unity--adobecom.aem.page/?martech=off Co-authored-by: Ryan Clayton <rclayton@adobe.com>
…in (#657) * Load milo libs from adobe.com for acrobat.adobe.com domain Resolves: [MWPW-185735](https://jira.corp.adobe.com/browse/MWPW-185735) **Test URLs:** Will be tested on stage.acrobat.adobe.com Note: This will need to be merged once akamai mapping is done on stage.acrobat.adobe for frictionless page. More details in the jira ticket **Update:** DC side PR is merged and we are getting ready to test akamai setting on acrobat.adobe.com side
…t subdomain (#660) * Load error file from adobe.com on acrobat subdomain Resolves: [MWPW-186708](https://jira.corp.adobe.com/browse/MWPW-186708) **Test URLs:** - Before: https://main--unity--adobecom.aem.page/?martech=off - After: https://error-file--unity--adobecom.aem.page/?martech=off Note: this will be tested on stage.acrobat.adobe.com A quick test can be done on existing frictionless verb page to make sure nothing broken. Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro-2.local>
fixing progress bar flex-basis to 8px Resolves: [MWPW-171479](https://jira.corp.adobe.com/browse/MWPW-NUMBER) **Test URLs:** - Before: https://main--cc--adobecom.aem.page/products/photoshop/online?unitylibs=stage https://main--cc--adobecom.aem.page/products/photoshop-lightroom/lightroom-presets https://main--dc--adobecom.aem.live/drafts/nala/acrobat/online/test/compress-pdf - After: https://main--cc--adobecom.aem.page/products/photoshop/online?unitylibs=MWPW-171479 https://main--cc--adobecom.aem.page/products/photoshop-lightroom/lightroom-presets?unitylibs=MWPW-171479 https://main--dc--adobecom.aem.live/drafts/nala/acrobat/online/test/compress-pdf?unitylibs=MWPW-171479 Co-authored-by: Ruchika Sinha <69535463+Ruchika4@users.noreply.github.com> Co-authored-by: Sanjay Saravanan <75960494+sanjayms01@users.noreply.github.com> Co-authored-by: vipulg <vipulg@adobe.com>
* Fix tab trap issue Resolves: [MWPW-186857](https://jira.corp.adobe.com/browse/MWPW-186857) **Test URLs:** - Before: https://mwpw-183216-a11y-play-pause--cc--adobecom.aem.live/products/firefly?unitylibs=stage - After: https://mwpw-183216-a11y-play-pause--cc--adobecom.aem.live/products/firefly?unitylibs=tab --------- Co-authored-by: Ruchika Sinha <tek10248@Ruchikas-MacBook-Pro-2.local>
…t subdomain (#665) * Load error file from adobe.com on acrobat subdomain Resolves: [MWPW-186708](https://jira.corp.adobe.com/browse/MWPW-186708) **Test URLs:** - Before: https://main--unity--adobecom.aem.page/?martech=off - After: https://error-file--unity--adobecom.aem.page/?martech=off Note: this will be tested on stage.acrobat.adobe.com A quick test can be done on existing frictionless verb page to make sure nothing broken.
…(Phase 1) (#663) * Consumed dc-pdflite library into unity repo * Implemented logic to parse pdf file details to retrieve page count * Added page count validation prior to file upload * Removed unnecessary API call to fetch file metadata for page count Resolves: [MWPW-164353](https://jira.corp.adobe.com/browse/MWPW-164353) **Testing Details:** - Please refer to the acrobat verb error spreadsheet to identify the verbs that have page count limits - Test against those limits for the different verbs to ensure that both max page count as well as min page count is respected - Error toast should still appear with the appropriate error message in case of validation failures - NOTES: -- Single File: If there is a page count failure, the error toast will appear and no file upload will occur. This differs from experience on production since page count check is performed during transition screen. Now, transition screen won't even appear with this code update. -- Multi File: If all files fail with the page count check, then the error toast for page count limit will appear. If all files fail but for different reasons, then the first client side error toast will appear (same as on production today). If even one file is valid, the upload will continue and file will be processed (same as on production today). **Test URLs:** - Before: https://main--dc--adobecom.aem.page/acrobat/online/ai-chat-pdf?unitylibs=stage - After: https://main--dc--adobecom.aem.page/acrobat/online/ai-chat-pdf?unitylibs=MWPW-164353
Issue: `/ibs` under root is not accessible over adobe.com. - Updating pdflite libs path to fall under `unitylibs` folder - Potentially will be reverted in later phases as will require akamai support to enable access to root `libs` folder (if shift needed) Resolves: [MWPW-164353](https://jira.corp.adobe.com/browse/MWPW-164353) **Test URLs:** - Before: https://main--dc--adobecom.aem.page/acrobat/online/ai-chat-pdf?unitylibs=stage - After: https://main--dc--adobecom.aem.page/acrobat/online/ai-chat-pdf?unitylibs=MWPW-164353-path-fix
sanjayms01
approved these changes
Jan 29, 2026
vipu0303
approved these changes
Jan 29, 2026
Collaborator
|
Done with the stage validation. All looks fine. Test Results are in the task: MWPW-186420 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[MWPW-186708][Domain routing]Load error file from adobe.com on acrobat subdomain
[MWPW-186857]Fix tab trap issue (
[MWPW-171479] fixing the grey-line issue (
[MWPW-186708][Domain routing]Load error file from adobe.com on acrobat subdomain (
[MWPW-185735]Load milo libs from adobe.com for acrobat.adobe.com domain (
[MWPW-182131] Automatic invalidating CDN cache (
[MWPW-164353] Implementing dc-pdflite library to check file page count (Phase 1)(
[MWPW-164353] Updating pdflite libs path (
Test URLs:
Before: https://main--cc--adobecom.aem.live/products/firefly?unitylibs=main
After: https://main--cc--adobecom.aem.live/products/firefly?unitylibs=stage
Before: https://stage--dc--adobecom.aem.page/acrobat/online/pdf-to-png?unitylibs=main
After: https://stage--dc--adobecom.aem.page/acrobat/online/pdf-to-png?unitylibs=stage