Make changes around padding and margins to reduce vertical whitespace…#1818
Merged
Make changes around padding and margins to reduce vertical whitespace…#1818
Conversation
Collaborator
leoniedickson
left a comment
leoniedickson
left a comment
There was a problem hiding this comment.
It's definitely looking nicer! Was having a look with the GPChronicConditionManagementPlan form and noticed there were a few spots where the container borders are touching - maybe unintentionally?
Also just had another thought that the add item buttons could possibly be moved to sit next to the remove icon on the last item to get rid of that vertical space where the button is now (bad mockup below) - just an idea though!
Looks like prettier might also need to be run to get that check passing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… on the screen.