Skip to content

Update arima.py#3

Open
vkverma9534 wants to merge 1 commit intoaeon-toolkit:masterfrom
vkverma9534:patch-1
Open

Update arima.py#3
vkverma9534 wants to merge 1 commit intoaeon-toolkit:masterfrom
vkverma9534:patch-1

Conversation

@vkverma9534
Copy link
Copy Markdown

Fix duplicated ARMA model entry in stationary_arma_models

Fix duplicated ARMA model entry in stationary_arma_models
@vkverma9534
Copy link
Copy Markdown
Author

Fix duplicated ARMA model entry in stationary_arma_models.

The dictionary had duplicate (p, q) keys which caused earlier entries
to be silently overwritten. This change ensures benchmark correctness.
We need to find an approach so that if the data might be used later we can save it as a dictionary with multiple parameter (as I did) or we remove the ones (in case of redundancy) which will not be used later as dictionary will only use the last assignment as final without even giving a warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant