Open
Conversation
eanzhao
changed the title
arg-foo
suggested changes
Mar 26, 2025
| public const string StateHandlerDefaultMethodName = "HandleStateAsync"; | ||
| public const string ConfigDefaultMethodName = "PerformConfigAsync"; | ||
| public const string ForwardEventMethodName = "ForwardEventAsync"; | ||
| public const int EventDispatcherMaxBatchSize = 20; |
Contributor
There was a problem hiding this comment.
I can't find the use of this anywhere
src/Aevatar.Core/GAgentBase.cs
Outdated
| } | ||
|
|
||
| private IAsyncStream<EventWrapperBase> GetEventBaseStream(GrainId grainId) | ||
| private IAsyncStream<EventWrapperBase> GetEventBaseStreamForOwn(GrainId grainId) |
Contributor
There was a problem hiding this comment.
This naming convention is very difficult to understand. Can't really explain how for own is linked to its implementation.
Contributor
There was a problem hiding this comment.
How about changing it to GetEventBaseUpwardsStream?
src/Aevatar.Core/GAgentBase.cs
Outdated
| } | ||
|
|
||
| private IAsyncStream<StateWrapper<TState>> GetStateProjectionStream() | ||
| private IAsyncStream<EventWrapperBase> GetEventBaseStreamForChildren(GrainId grainId) |
Contributor
There was a problem hiding this comment.
GetEventBaseDownwardStream what do you think?
eanzhao
changed the title
eanzhao
changed the title
eanzhao
force-pushed
the
feature/stream-refactor
branch
from
ec41571 to
6b45438
Compare
eanzhao
changed the title
eanzhao
force-pushed
the
feature/stream-refactor
branch
from
36b8b31 to
e188a82
Compare
arg-foo
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.