Skip to content
This repository was archived by the owner on Mar 31, 2026. It is now read-only.

Whitelist mcp servers and use a controller to manage them#1033

Open
eanzhao wants to merge 23 commits intodevfrom
feature/mcp-whitelist
Open

Whitelist mcp servers and use a controller to manage them#1033
eanzhao wants to merge 23 commits intodevfrom
feature/mcp-whitelist

Conversation

@eanzhao
Copy link
Copy Markdown
Contributor

@eanzhao eanzhao commented Aug 4, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov Bot commented Aug 5, 2025

Codecov Report

❌ Patch coverage is 85.44061% with 38 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...Aevatar.HttpApi/Controllers/McpServerController.cs 90.59% 9 Missing and 10 partials ⚠️
...rc/Aevatar.HttpApi/Services/McpExtensionWrapper.cs 0.00% 13 Missing ⚠️
...r.Application.Contracts/Mcp/GetMcpServerListDto.cs 83.33% 4 Missing ⚠️
...tation/src/Aevatar.HttpApi/AevatarHttpApiModule.cs 0.00% 2 Missing ⚠️

Impacted file tree graph

@@            Coverage Diff             @@
##              dev    #1033      +/-   ##
==========================================
- Coverage   56.35%   53.88%   -2.48%     
==========================================
  Files         359      398      +39     
  Lines       12597    13546     +949     
  Branches     1182     1250      +68     
==========================================
+ Hits         7099     7299     +200     
- Misses       5095     5836     +741     
- Partials      403      411       +8     
Flag Coverage Δ
unittests 53.88% <85.44%> (-2.48%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ar.Application.Contracts/Mcp/CreateMcpServerDto.cs 100.00% <100.00%> (ø)
.../Aevatar.Application.Contracts/Mcp/McpServerDto.cs 100.00% <100.00%> (ø)
...ar.Application.Contracts/Mcp/UpdateMcpServerDto.cs 100.00% <100.00%> (ø)
...tation/src/Aevatar.HttpApi/AevatarHttpApiModule.cs 0.00% <0.00%> (ø)
...r.Application.Contracts/Mcp/GetMcpServerListDto.cs 83.33% <83.33%> (ø)
...rc/Aevatar.HttpApi/Services/McpExtensionWrapper.cs 0.00% <0.00%> (ø)
...Aevatar.HttpApi/Controllers/McpServerController.cs 90.59% <90.59%> (ø)

... and 36 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

/// <summary>
/// Implementation of MCP extension wrapper that calls the actual extension methods
/// </summary>
public class McpExtensionWrapper : IMcpExtensionWrapper
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This class is unnecessary since it is essentially gAgentFactory. I think the main thing to implement is how to separate the logic in GetMCPWhiteListAsync and ConfigMCPWhitelistAsync from gAgentFactory.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants