Refactor/2026 03 22 architecture audit remediation#73
Closed
Conversation
- Changed API endpoint URLs from `http://localhost:5000` to `http://localhost:5100` across multiple documentation files and code references. - Updated the `README.md`, SDK documentation, and various guides to reflect the new default base URL. - Introduced new interfaces for script catalog commands and queries, enhancing the scripting capabilities. - Refactored workflow reporting classes to use the new `WorkflowRunExportDocument` instead of the deprecated `WorkflowRunReport`. - Improved command interaction services to ensure proper handling of cancellation tokens during cleanup operations.
- Introduced a new property `DefaultListenUrls` in `AevatarDefaultHostOptions` to specify default listening addresses. - Implemented logic in `WebApplicationBuilderExtensions` to apply default listen URLs when no explicit configuration is provided. - Updated the `Program.cs` to set the default listen URL to `http://localhost:5100`. - Enhanced tests to verify that default listen URLs are applied correctly and do not override explicit configurations. - Updated documentation to reflect the new default listening behavior.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces several important improvements and cleanup tasks across the codebase, primarily focused on architecture audit remediation, configuration consistency, dependency boundary enforcement, and naming unification. The most significant changes include the addition of a comprehensive architecture audit scorecard, unification of API default ports and documentation, improved host configuration flexibility, CQRS cleanup token propagation, scripting dependency boundary tightening, and workflow export naming alignment.
Architecture audit and documentation:
docs/audit-scorecard/2026-03-22-aevatar-architecture-audit-scorecard.md.Configuration and documentation consistency:
5100instead of5000for API endpoints, ensuring consistency for users and developers. [1] [2] [3] [4] [5] [6] [7] [8]Host configuration improvements:
AevatarDefaultHostOptionsandWebApplicationBuilderExtensionsto allow specifying aDefaultListenUrlsproperty, which sets the default listen URLs for the web host unless explicitly overridden in configuration. [1] [2] [3] [4] [5]CQRS and scripting boundary cleanup:
CancellationToken.Noneusages with tokens from shutdown signals to improve graceful shutdown and cleanup behavior. [1] [2] [3] [4] [5]Aevatar.GAgentService.Applicationby referencingAevatar.Scripting.Abstractionsinstead of the internalAevatar.Scripting.Core, enforcing proper abstraction layering.Workflow export naming alignment:
WorkflowRunReporttoWorkflowRunExportDocumentthroughout the codebase and documentation, improving naming clarity and consistency. [1] [2] [3]