Conversation
…alidation and execution contracts
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3b54e054f0
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| builder.Services.AddAuthentication(JwtBearerDefaults.AuthenticationScheme) | ||
| .AddJwtBearer(jwt => | ||
| { | ||
| jwt.Authority = options.Authority; | ||
| jwt.RequireHttpsMetadata = options.RequireHttpsMetadata; | ||
|
|
||
| jwt.TokenValidationParameters.ValidAudience = options.Audience; | ||
| jwt.TokenValidationParameters.ValidateAudience = !string.IsNullOrWhiteSpace(options.Audience); | ||
| }); |
There was a problem hiding this comment.
Switching the Mainnet host to JWT bearer here breaks the existing Studio browser flow, because the Studio client still calls /api/auth/me and the rest of the Studio APIs with plain same-origin fetch and no Authorization header (apps/aevatar-console-web/src/shared/studio/api.ts:32-39, plus the test at api.test.ts:48-50). The old sidecar auth worked via browser cookies, but after this change every Studio request will stay anonymous unless the frontend is updated in the same commit to use authFetch(), so a signed-in console user will still be treated as logged out by the new host.
Useful? React with 👍 / 👎.
| BrowserLauncher.Open(baseUrl); | ||
| Console.WriteLine($"Opened browser: {baseUrl}"); |
There was a problem hiding this comment.
aevatar app is now described as opening the UI, but this line opens the host root URL directly. In this refactor the host root is only the JSON health endpoint (src/Aevatar.Bootstrap/Hosting/WebApplicationBuilderExtensions.cs:93-95), while the actual console entrypoint is the /studio route (apps/aevatar-console-web/src/app.tsx:36-39). On a successful run, users land on raw health JSON instead of the Studio app.
Useful? React with 👍 / 👎.
| var configured = CliAppConfigStore.GetApiBaseUrl(out _); | ||
| return configured?.TrimEnd('/') ?? "http://localhost:6688"; |
There was a problem hiding this comment.
The fallback URL still points to http://localhost:6688, but this change moved the Studio backend to the Mainnet host and the new local startup paths still use port 5080 (tools/Aevatar.Tools.Cli/boot.sh:18-19, apps/aevatar-console-web/config/proxy.ts:12-16). On a clean checkout with no saved CLI config, following the printed dotnet run --project src/Aevatar.Mainnet.Host.Api instruction will be reported as "not reachable" unless the user also remembers to pass --url manually.
Useful? React with 👍 / 👎.
…constraints
- Replaced `@umijs/max` history import with a local navigation shim in multiple console web pages for improved consistency.
- Enhanced port constraint documentation to prohibit the use of port `5000` across all services, ensuring alignment with system requirements.
- Added new endpoints for `/primitives` and `/actors/{actorId}/graph-enriched` in the ChatQuery API, with corresponding tests to validate functionality.
- Updated various tests to reflect changes in the workflow and ensure comprehensive coverage.
…te default Studio URL and port in CLI.
…vocation, lifecycle, and scope management, including error handling.
… 5100 and clean up unused usings.
1 participant
No description provided.