fix: use API.callJsonApi in speech-store loadSettings to prevent settings load error#1456
Open
gdeyoung wants to merge 1 commit intoagent0ai:mainfrom
Open
fix: use API.callJsonApi in speech-store loadSettings to prevent settings load error#1456gdeyoung wants to merge 1 commit intoagent0ai:mainfrom
gdeyoung wants to merge 1 commit intoagent0ai:mainfrom
Conversation
…ings load error The loadSettings() method used raw fetchApi() which does not handle token exchange or error responses properly. The callJsonApi wrapper handles serialization, error responses, and extension hooks correctly. Fixes persistent console error on speech settings load.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: Speech Store Settings Load Error
Problem
The
loadSettings()method inspeech-store.jsuses rawfetchApi()which does not handle token exchange or error responses properly, causing persistent console errors when speech settings fail to load.Solution
Replace raw
fetchApi()with the existingAPI.callJsonApi()wrapper which properly handles:Changes
import * as API from "/js/api.js"to speech-store.jsloadSettings()withAPI.callJsonApi("settings_get", null)Testing
Related