Skip to content

fix: graceful recovery from malformed LLM tool call output #1458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gdeyoung wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −1
Open

fix: graceful recovery from malformed LLM tool call output #1458

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -875,7 +875,11 @@ async def process_tools(self, msg: str):
# Only validate when extraction produced an object; None means no JSON tool
# block was found — the misformat warning path below handles that.
if tool_request is not None:
await self.validate_tool_request(tool_request)
try:
await self.validate_tool_request(tool_request)
except ValueError:
# Malformed JSON from LLM — treat as misformat, not fatal crash
tool_request = None

if tool_request is not None:
raw_tool_name = tool_request.get("tool_name", tool_request.get("tool","")) # Get the raw tool name
Expand Down