fix(AIP-133): remove REQUIRED from the resource_id field.#1221
Open
yihanzhen wants to merge 2 commits intoaip-dev:masterfrom
Open
fix(AIP-133): remove REQUIRED from the resource_id field.#1221yihanzhen wants to merge 2 commits intoaip-dev:masterfrom
yihanzhen wants to merge 2 commits intoaip-dev:masterfrom
Conversation
yihanzhen
changed the title
yihanzhen
changed the title
Collaborator
|
@yihanzhen can you add a bit of description with the rationale please? Thanks! |
Contributor
Author
|
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It is misleading to annotate
book_idwithREQUIREDin the example because in many cases, clients can/must omit the resource id and let the server pick one.