feat(AIP-202): add Type References section#1345
Open
noahdietz wants to merge 11 commits intoaip-dev:masterfrom
Open
feat(AIP-202): add Type References section#1345noahdietz wants to merge 11 commits intoaip-dev:masterfrom
noahdietz wants to merge 11 commits intoaip-dev:masterfrom
Conversation
noahdietz
requested review from
andrei-scripniciuc,
itsStrobe and
jskeet
and removed request for
itsStrobe
andrei-scripniciuc
approved these changes
Apr 22, 2024
jskeet
approved these changes
Apr 23, 2024
Contributor
jskeet
left a comment
jskeet
left a comment
There was a problem hiding this comment.
Generally happy - some tweaks suggested.
jskeet
approved these changes
Apr 23, 2024
Contributor
jskeet
left a comment
jskeet
left a comment
There was a problem hiding this comment.
Looks even better to me now :)
pinalbaldha
approved these changes
May 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stage AIP update for new
google.api.FieldInfo.referenced_typesfield in AIP-202 and guidance for using it onAnyfields in AIP-146.