Skip to content

"Disconnect all" Removed button from settings#6

Merged
akemmanuel merged 1 commit intomasterfrom
opencode/issue4-20260302214049
Mar 3, 2026
Merged

"Disconnect all" Removed button from settings#6
akemmanuel merged 1 commit intomasterfrom
opencode/issue4-20260302214049

Conversation

@opencode-agent
Copy link
Contributor

@opencode-agent opencode-agent bot commented Mar 2, 2026

Done. I removed the "Disconnect all" button from the settings in src/components/ConnectionPanel.tsx. The changes include:

  1. Removed the "Disconnect all" button (lines 422-436)
  2. Removed unused disconnect variable from the destructuring
  3. Removed unused isConnected variable
  4. Removed unused hasAnyConnection import

Lint passes successfully. The "Add project" button remains as it's already outside of settings (in the form's submit button).

Closes #4

New%20session%20-%202026-03-02T21%3A40%3A48.319Z
opencode session  |  github run

Removed button from settings

Co-authored-by: akemmanuel <akemmanuel@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

User opencode-agent[bot] does not have write permissions

github run

@akemmanuel akemmanuel closed this Mar 3, 2026
@akemmanuel akemmanuel reopened this Mar 3, 2026
@opencode-agent
Copy link
Contributor Author

opencode-agent bot commented Mar 3, 2026

Code Review: "Disconnect all" PR

Confidence Score: 4/5


Issues Detected

1. Potential UX Issue - Missing Disconnect Functionality

While the PR removes the "Disconnect all" button from settings as intended (issue #4), there's no alternative way provided for users to disconnect all connections. Users may still need this functionality.

// Before: User could disconnect from settings
// After: No way to disconnect connections exists in the UI

Recommendation: Either:

  • Add a disconnect option elsewhere in the UI (e.g., in the connection list items)
  • Or confirm this is intentional behavior for the issue being addressed

2. Minor: PR Description Accuracy

The PR description states: "The 'Add project' button remains as it's already outside of settings (in the form's submit button)"

This is slightly misleading - the "Add project" button wasn't in settings to begin with; it's in the AddProjectForm component which is in the "Add Project" tab, not the Settings tab.


Code Quality Assessment

The actual code changes are clean and correct:

  • ✅ Unused variables properly removed (disconnect, isConnected, hasAnyConnection)
  • ✅ Import statements correctly cleaned up
  • ✅ UI layout adjusted properly (changed from justify-between to justify-end)
  • ✅ No syntax errors or TypeScript issues
  • ✅ The Unplug icon is still used elsewhere in the file (line 290), so no unused import

Summary

Aspect Status
Bug introduction None detected
Code quality Good
Unused code removal Correct
UX consideration Potential concern (feature removal)

The code changes are technically sound. The main consideration is whether completely removing the disconnect functionality is the desired outcome, or if an alternative should be provided elsewhere in the UI.

New%20session%20-%202026-03-03T11%3A41%3A46.899Z
opencode session  |  github run

@akemmanuel akemmanuel merged commit c4ad719 into master Mar 3, 2026
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The "Disconnect all" button does not make sense

1 participant