Skip to content

Moved theme toggle to Settings#7

Merged
akemmanuel merged 1 commit intomasterfrom
opencode/issue5-20260302214333
Mar 2, 2026
Merged

Moved theme toggle to Settings#7
akemmanuel merged 1 commit intomasterfrom
opencode/issue5-20260302214333

Conversation

@opencode-agent
Copy link
Contributor

@opencode-agent opencode-agent bot commented Mar 2, 2026

Done. The dark mode / light mode toggle has been moved from the app header (TitleBar.tsx) to the Settings dialog (ConnectionPanel.tsx > GeneralSettings). The toggle now appears in Settings > General with a "Dark mode" label, consistent with other settings.

Closes #5

New%20session%20-%202026-03-02T21%3A43%3A32.427Z
opencode session  |  github run

Co-authored-by: akemmanuel <akemmanuel@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

User opencode-agent[bot] does not have write permissions

github run

@akemmanuel akemmanuel closed this Mar 2, 2026
@akemmanuel akemmanuel reopened this Mar 2, 2026
@github-actions
Copy link

github-actions bot commented Mar 2, 2026

Based on my review, here's my analysis:


Confidence Score: 4/5


Issues Found

1. Visual Inconsistency in Settings UI (Medium)

Location: src/components/ConnectionPanel.tsx:464-470

The Dark mode setting lacks an icon while other settings have icons:

  • STT endpoint: has <Mic /> icon
  • Notifications: has <Bell /> icon
  • Dark mode: no icon
// Current code - missing icon
<div className="flex items-center justify-between gap-3">
    <div className="flex items-center gap-2">
        <Label className="text-sm font-normal">Dark mode</Label>
    </div>
    <ThemeToggle />
</div>

Suggested fix: Add a Moon/Sun icon to match other settings:

<div className="flex items-center justify-between gap-3">
    <div className="flex items-center gap-2">
        <Moon className="size-4 text-muted-foreground" />
        <Label className="text-sm font-normal">Dark mode</Label>
    </div>
    <ThemeToggle />
</div>

2. Inconsistent Control Type (Low)

Location: src/components/ConnectionPanel.tsx

The Dark mode uses a Button (ThemeToggle) while Notifications uses a Switch component. This creates an inconsistent interaction pattern in the settings panel.


Summary

The PR successfully moves the theme toggle from TitleBar to Settings. The code changes are minimal and functional. The main issues are:

  1. Missing icon - breaks visual consistency with other settings
  2. Different control type - button vs switch creates UX inconsistency

These are minor UI/UX issues rather than bugs. The functionality appears correct.

New%20session%20-%202026-03-02T21%3A48%3A27.036Z
opencode session  |  github run

@akemmanuel akemmanuel merged commit ee08ae4 into master Mar 2, 2026
5 of 6 checks passed
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

User opencode-agent[bot] does not have write permissions

github run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moving the color modes toggle

1 participant