Merged
Conversation
Co-authored-by: akemmanuel <akemmanuel@users.noreply.github.com>
|
User opencode-agent[bot] does not have write permissions |
|
Based on my review, here's my analysis: Confidence Score: 4/5Issues Found1. Visual Inconsistency in Settings UI (Medium)Location: The Dark mode setting lacks an icon while other settings have icons:
// Current code - missing icon
<div className="flex items-center justify-between gap-3">
<div className="flex items-center gap-2">
<Label className="text-sm font-normal">Dark mode</Label>
</div>
<ThemeToggle />
</div>Suggested fix: Add a Moon/Sun icon to match other settings: <div className="flex items-center justify-between gap-3">
<div className="flex items-center gap-2">
<Moon className="size-4 text-muted-foreground" />
<Label className="text-sm font-normal">Dark mode</Label>
</div>
<ThemeToggle />
</div>2. Inconsistent Control Type (Low)Location: The Dark mode uses a SummaryThe PR successfully moves the theme toggle from TitleBar to Settings. The code changes are minimal and functional. The main issues are:
These are minor UI/UX issues rather than bugs. The functionality appears correct. |
|
User opencode-agent[bot] does not have write permissions |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Done. The dark mode / light mode toggle has been moved from the app header (TitleBar.tsx) to the Settings dialog (ConnectionPanel.tsx > GeneralSettings). The toggle now appears in Settings > General with a "Dark mode" label, consistent with other settings.
Closes #5
opencode session | github run