Conversation
Contributor
ragoune
commented
Mar 17, 2025
ragoune
commented
- Improve the AddComponentsN performances, reusing the entityRecord instead of fetching it multiple times.
- Fix the AddComponentsN: when called multiple times on one entity, we correctly set the Archetype and move all the components to it.
Re use the entityRecord instead of fetching it in all sub functions
AddComponentsN were not meant to be used multiple time on the same entity. But in the Arche benchmark it is required to add 10 components (AddComponents8 and AddComponents3). This resulted to the entity having only 3 components and being attache to the archetype of those 3 components. The 8 other components were lost in memory, in their storage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.