Conversation
|
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the
Comment |
renovate
Bot
force-pushed
the
renovate/all
branch
3 times, most recently
from
b4ca1a9 to
6f34e09
Compare
renovate
Bot
force-pushed
the
renovate/all
branch
9 times, most recently
from
c0482ef to
94fa4c2
Compare
renovate
Bot
force-pushed
the
renovate/all
branch
from
94fa4c2 to
8c68b5a
Compare
renovate
Bot
force-pushed
the
renovate/all
branch
3 times, most recently
from
6364ec5 to
d85504c
Compare
renovate
Bot
force-pushed
the
renovate/all
branch
from
d85504c to
91bbc1a
Compare
commit: |
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
There was a problem hiding this comment.
Pull request overview
This PR updates multiple dependencies across the codebase, with the most significant change being the upgrade from ESLint v9 to v10, which includes breaking changes. The PR also includes necessary code adjustments to maintain compatibility and fixes a bug in the site overrides caching mechanism.
Changes:
- Upgraded ESLint from v9.39.2 to v10.0.2 with a compatibility patch for eslint-plugin-mdx
- Updated
@rspresspackages from v2.0.2 to v2.0.3 - Updated various development dependencies and GitHub Actions versions
- Fixed variable shadowing issues in OpenAPI components
- Fixed a bug in useSiteOverrides where the module-level cache wasn't being populated
- Added Playwright to the Renovate ignore list
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| yarn.lock | Updated lockfile with new dependency versions including ESLint v10, @rspress v2.0.3, and various other packages |
| patches/eslint-plugin-mdx+3.6.2.patch | Added new patch to make eslint-plugin-mdx compatible with ESLint v10 by using fallback for deprecated context methods |
| packages/doom/src/runtime/hooks/useSiteOverrides.ts | Fixed bug where const prevented populating the module-level cache variable |
| packages/doom/src/runtime/components/OpenAPIRef.tsx | Renamed innerUid to innerId to avoid variable shadowing |
| packages/doom/src/runtime/components/OpenAPIPath.tsx | Renamed uid to id to avoid variable shadowing |
| packages/doom/package.json | Updated dependency versions for @cspell, @eslint-react, @InQuirer, @RsPress, eslint, mermaid, openai, simple-git, string-width, type-fest, and typescript-eslint |
| package.json | Updated devDependencies for @eslint/js, @swc/core, @types/node, eslint; added @rsbuild/core resolution to beta.5 |
| .renovaterc | Added JSON schema reference and configured Playwright packages to be ignored from automatic updates |
| .nvmrc | Updated Node.js version from v24.12.0 to v24.13.1 |
| .github/workflows/*.yml | Updated GitHub Actions: actions/checkout v6.0.1→v6.0.2, actions/setup-node v6.1.0→v6.2.0, autofix-ci/action v1.3.2→v1.3.3 |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (2)
.renovaterc (2)
6-9: Consider documenting why Playwright packages are pinned from auto-updates.This PR updates both
playwrightand@playwright/browser-chromiumto 1.58.2, then immediately excludes them from future Renovate automation. Maintainers will need to remember to update these manually going forward. A short rationale (e.g., via apackageRulesdescriptionfield or a repository comment) would prevent confusion later.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.renovaterc around lines 6 - 9, Add a short rationale explaining why Playwright packages "@playwright/browser-chromium" and "playwright" are excluded from Renovate: update the .renovaterc to either add a packageRules entry with a descriptive "description" field for these packages or include an inline repository comment near the "ignoreDeps" list that states why they are pinned and must be updated manually (e.g., pinned due to stability/CI compatibility or pinned browser bundle handling), so future maintainers understand the intended process.
6-9: Playwright packages will require manual updates going forward — confirm this is intentional.
ignoreDepsis the correct top-level Renovate field and supports exact-match names, so the syntax is valid. However, this PR simultaneously bumpsplaywrightand@playwright/browser-chromiumto 1.58.2 and adds them toignoreDeps, meaning Renovate will never auto-propose updates for these packages again. If that's intentional (e.g., browser-binary lifecycle decoupled from package version), consider documenting the rationale—either as a repository note or via apackageRulesentry with adescription, so future maintainers don't wonder why these are silently excluded.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In @.renovaterc around lines 6 - 9, The Renovate config currently adds "@playwright/browser-chromium" and "playwright" to the top-level ignoreDeps, which will permanently stop Renovate proposing updates; decide whether this is intentional and either (a) remove those package names from ignoreDeps to allow normal Renovate bumps, or (b) keep them but document the rationale by adding a packageRules entry with a descriptive "description" explaining the lifecycle decoupling (or add a repository note) so future maintainers understand why these packages are excluded; reference the "ignoreDeps" field, the specific package names "@playwright/browser-chromium" and "playwright", and the "packageRules"/"description" keys when making the change.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In @.renovaterc:
- Around line 6-9: Add a short rationale explaining why Playwright packages
"@playwright/browser-chromium" and "playwright" are excluded from Renovate:
update the .renovaterc to either add a packageRules entry with a descriptive
"description" field for these packages or include an inline repository comment
near the "ignoreDeps" list that states why they are pinned and must be updated
manually (e.g., pinned due to stability/CI compatibility or pinned browser
bundle handling), so future maintainers understand the intended process.
- Around line 6-9: The Renovate config currently adds
"@playwright/browser-chromium" and "playwright" to the top-level ignoreDeps,
which will permanently stop Renovate proposing updates; decide whether this is
intentional and either (a) remove those package names from ignoreDeps to allow
normal Renovate bumps, or (b) keep them but document the rationale by adding a
packageRules entry with a descriptive "description" explaining the lifecycle
decoupling (or add a repository note) so future maintainers understand why these
packages are excluded; reference the "ignoreDeps" field, the specific package
names "@playwright/browser-chromium" and "playwright", and the
"packageRules"/"description" keys when making the change.
ℹ️ Review info
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
yarn.lockis excluded by!**/yarn.lock,!**/*.lock
📒 Files selected for processing (13)
.github/workflows/autofix.yml.github/workflows/ci.yml.github/workflows/gh-pages.yml.github/workflows/pkg-pr-new.yml.github/workflows/release.yml.nvmrc.renovatercpackage.jsonpackages/doom/package.jsonpackages/doom/src/runtime/components/OpenAPIPath.tsxpackages/doom/src/runtime/components/OpenAPIRef.tsxpackages/doom/src/runtime/hooks/useSiteOverrides.tspatches/eslint-plugin-mdx+3.6.2.patch
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: JounQin <admin@1stg.me>
This PR contains the following updates:
^9.39.2→^10.0.01.57.0→1.58.22.0.2→2.0.32.0.2→2.0.32.0.2→2.0.32.0.2→2.0.3v6.0.1→v6.0.2v6.1.0→v6.2.0v1.3.2→v1.3.3^9.39.2→^10.0.0^9.39.2→^10.0.024.12.0→24.13.11.57.0→1.58.2Release Notes
eslint/eslint (@eslint/js)
v10.0.1Compare Source
v10.0.0Compare Source
Breaking Changes
f9e54f4feat!: estimate rule-tester failure location (#20420) (ST-DDT)a176319feat!: replacechalkwithstyleTextand addcolortoResultsMeta(#20227) (루밀LuMir)c7046e6feat!: enable JSX reference tracking (#20152) (Pixel998)fa31a60feat!: addnameto configs (#20015) (Kirk Waiblinger)3383e7efix!: remove deprecatedSourceCodemethods (#20137) (Pixel998)501abd0feat!: update dependency minimatch to v10 (#20246) (renovate[bot])ca4d3b4fix!: stricter rule tester assertions for valid test cases (#20125) (唯然)96512a6fix!: Remove deprecated rule context methods (#20086) (Nicholas C. Zakas)c69fdacfeat!: remove eslintrc support (#20037) (Francesco Trotta)208b5ccfeat!: UseScopeManager#addGlobals()(#20132) (Milos Djermanovic)a2ee188fix!: adduniqueItems: trueinno-invalid-regexpoption (#20155) (Tanuj Kanti)a89059dfeat!: Program range span entire source text (#20133) (Pixel998)39a6424fix!: assert 'text' is a string across all RuleFixer methods (#20082) (Pixel998)f28fbf8fix!: Deprecate"always"and"as-needed"options of theradixrule (#20223) (Milos Djermanovic)aa3fb2bfix!: tightenfunc-namesschema (#20119) (Pixel998)f6c0ed0feat!: reporteslint-envcomments as errors (#20128) (Francesco Trotta)4bf739ffix!: remove deprecatedLintMessage#nodeTypeandTestCaseError#type(#20096) (Pixel998)523c076feat!: drop support for jiti < 2.2.0 (#20016) (michael faith)454a292feat!: updateeslint:recommendedconfiguration (#20210) (Pixel998)4f880eefeat!: removev10_*and inactiveunstable_*flags (#20225) (sethamus)f18115cfeat!:no-shadow-restricted-namesreportglobalThisby default (#20027) (sethamus)c6358c3feat!: Require Node.js^20.19.0 || ^22.13.0 || >=24(#20160) (Milos Djermanovic)Features
bff9091feat: handleArray.fromAsyncinarray-callback-return(#20457) (Francesco Trotta)290c594feat: addselftono-implied-evalrule (#20468) (sethamus)43677defeat: fix handling of function and class expression names inno-shadow(#20432) (Milos Djermanovic)f0cafe5feat: rule tester add assertion optionrequireData(#20409) (fnx)f7ab693feat: output RuleTester test case failure index (#19976) (ST-DDT)7cbcbf9feat: addcountThisoption tomax-params(#20236) (Gerkin)f148a5efeat: add error assertion options (#20247) (ST-DDT)09e6654feat: update error loc ofrequire-yieldandno-useless-constructor(#20267) (Tanuj Kanti)Bug Fixes
436b82ffix: update eslint (#20473) (renovate[bot])1d29d22fix: detect defaultthisbinding inArray.fromAsynccallbacks (#20456) (Francesco Trotta)727451efix: fix regression of global mode report range instrictrule (#20462) (ntnyq)e80485ffix: remove fakeFlatESLintandLegacyESLintexports (#20460) (Francesco Trotta)9eeff3bfix: update esquery (#20423) (cryptnix)b34b938fix: useError.prepareStackTraceto estimate failing test location (#20436) (Francesco Trotta)51aab53fix: update eslint (#20443) (renovate[bot])23490b2fix: handle space before colon inRuleTesterlocation estimation (#20433) (Francesco Trotta)f244dbffix: useMessagePlaceholderDatatype from@eslint/core(#20348) (루밀LuMir)d186f8cfix: update eslint (#20427) (renovate[bot])2332262fix: error location should not modify error message in RuleTester (#20421) (Milos Djermanovic)ab99b21fix: ensurefilenameis passed as third argument toverifyAndFix()(#20405) (루밀LuMir)8a60f3bfix: removeecmaVersionandsourceTypefromParserOptionstype (#20415) (Pixel998)eafd727fix: removeTDZscope type (#20231) (jaymarvelz)39d1f51fix: correctScopetypings (#20404) (sethamus)2bd0f13fix: updateverifyandverifyAndFixtypes (#20384) (Francesco Trotta)ba6ebfafix: correct typings forloadESLint()andshouldUseFlatConfig()(#20393) (루밀LuMir)e7673aefix: correct RuleTester typings (#20105) (Pixel998)53e9522fix: strict removed formatters check (#20241) (ntnyq)b017f09fix: correctno-restricted-importmessages (#20374) (Francesco Trotta)Documentation
e978ddadocs: Update README (GitHub Actions Bot)4cecf83docs: Update README (GitHub Actions Bot)c79f0abdocs: Update README (GitHub Actions Bot)773c052docs: Update README (GitHub Actions Bot)f2962e4docs: documentmeta.docs.frozenproperty (#20475) (Pixel998)8e94f58docs: fix broken anchor links from gerund heading updates (#20449) (Copilot)1495654docs: Update README (GitHub Actions Bot)0b8ed5cdocs: document support for:isselector alias (#20454) (sethamus)1c4b33fdocs: Document policies about ESM-only dependencies (#20448) (Milos Djermanovic)3e5d38cdocs: add missing indentation space in rule example (#20446) (fnx)63a0c7cdocs: Update README (GitHub Actions Bot)65ed0c9docs: Update README (GitHub Actions Bot)b0e4717docs: [no-await-in-loop] Expand inapplicability (#20363) (Niklas Hambüchen)fca421fdocs: Update README (GitHub Actions Bot)d925c54docs: update config syntax inno-lone-blocks(#20413) (Pixel998)7d5c95fdocs: remove redundantsourceType: "module"from rule examples (#20412) (Pixel998)02e7e71docs: correct.mtsglob pattern in files with extensions example (#20403) (Ali Essalihi)264b981docs: Update README (GitHub Actions Bot)5a4324fdocs: clarify"local"option ofno-unused-vars(#20385) (Milos Djermanovic)e593aa0docs: improve clarity, grammar, and wording in documentation site README (#20370) (Aditya)3f5062edocs: Add messages property to rule meta documentation (#20361) (Sabya Sachi)9e5a5c2docs: removeExamplesheadings from rule docs (#20364) (Milos Djermanovic)194f488docs: Update README (GitHub Actions Bot)0f5a94adocs: [class-methods-use-this] explain purpose of rule (#20008) (Kirk Waiblinger)df5566fdocs: add Options section to all rule docs (#20296) (sethamus)adf7a2bdocs: no-unsafe-finally note for generator functions (#20330) (Tom Pereira)ef7028cdocs: Update README (GitHub Actions Bot)fbae5d1docs: consistently use "v10.0.0" in migration guide (#20328) (Pixel998)778aa2ddocs: ignoring default file patterns (#20312) (Tanuj Kanti)4b5dbcddocs: reorder v10 migration guide (#20315) (Milos Djermanovic)5d84a73docs: Update README (GitHub Actions Bot)37c8863docs: fix incorrect anchor link in v10 migration guide (#20299) (Pixel998)077ff02docs: add migrate-to-10.0.0 doc (#20143) (唯然)3822e1bdocs: Update README (GitHub Actions Bot)Build Related
9f08712Build: changelog update for 10.0.0-rc.2 (Jenkins)1e2c449Build: changelog update for 10.0.0-rc.1 (Jenkins)c4c72a8Build: changelog update for 10.0.0-rc.0 (Jenkins)7e4daf9Build: changelog update for 10.0.0-beta.0 (Jenkins)a126a2abuild: add .scss files entry to knip (#20389) (Francesco Trotta)f5c0193Build: changelog update for 10.0.0-alpha.1 (Jenkins)165326fBuild: changelog update for 10.0.0-alpha.0 (Jenkins)Chores
1ece282chore: ignore/docs/v9.xin link checker (#20452) (Milos Djermanovic)034e139ci: add type integration test for@html-eslint/eslint-plugin(#20345) (sethamus)f3fbc2fchore: set@eslint/jsversion to 10.0.0 to skip releasing it (#20466) (Milos Djermanovic)afc0681chore: remove scopeManager.addGlobals patch for typescript-eslint parser (#20461) (fnx)3e5a173refactor: use types from@eslint/plugin-kit(#20435) (Pixel998)11644b1ci: rename workflows (#20463) (Milos Djermanovic)2d14173chore: fix typos in docs and comments (#20458) (o-m12a)6742f92test: add endLine/endColumn to invalid test case in no-alert (#20441) (경하)3e22c82test: add missing location data to no-template-curly-in-string tests (#20440) (Haeun Kim)b4b3127chore: package.json update for @eslint/js release (Jenkins)f658419refactor: removerawparser option from JS language (#20416) (Pixel998)2c3efb7chore: removecategoryfrom type test fixtures (#20417) (Pixel998)36193fdchore: removecategoryfrom formatter test fixtures (#20418) (Pixel998)e8d203bchore: add JSX language tag validation tocheck-rule-examples(#20414) (Pixel998)bc465a1chore: pin dependencies (#20397) (renovate[bot])703f0f5test: replace deprecated rules inlintertests (#20406) (루밀LuMir)ba71baatest: enablestrictmode in type tests (#20398) (루밀LuMir)f9c4968refactor: removelib/linter/rules.js(#20399) (Francesco Trotta)6f1c48echore: updates for v9.39.2 release (Jenkins)54bf0a3ci: create package manager test (#20392) (루밀LuMir)3115021refactor: simplify JSDoc comment detection logic (#20360) (Pixel998)4345b17chore: update@eslint-community/regexppto4.12.2(#20366) (루밀LuMir)772c9eechore: update dependency @eslint/eslintrc to ^3.3.3 (#20359) (renovate[bot])0b14059chore: package.json update for @eslint/js release (Jenkins)d6e7bf3ci: bump actions/checkout from 5 to 6 (#20350) (dependabot[bot])139d456chore: require mandatory headers in rule docs (#20347) (Milos Djermanovic)3b0289cchore: remove unused.eslintignoreand test fixtures (#20316) (Pixel998)a463e7bchore: update dependency js-yaml to v4 [security] (#20319) (renovate[bot])ebfe905chore: remove redundant rules from eslint-config-eslint (#20327) (Milos Djermanovic)88dfdb2test: add regression tests for message placeholder interpolation (#20318) (fnx)6ed0f75chore: skip type checking ineslint-config-eslint(#20323) (Francesco Trotta)1e2cad5chore: package.json update for @eslint/js release (Jenkins)9da2679chore: update@eslint/*dependencies (#20321) (Milos Djermanovic)0439794refactor: use types from @eslint/core (#20235) (jaymarvelz)cb51ec2test: cleanupSourceCode#traversetests (#20289) (Milos Djermanovic)897a347chore: remove restriction fortypein rule tests (#20305) (Pixel998)d972098chore: ignore prettier updates in renovate to keep in sync with trunk (#20304) (Pixel998)a086359chore: remove redundantfast-globdev-dependency (#20301) (루밀LuMir)564b302chore: installprettieras a dev dependency (#20302) (michael faith)8257b57refactor: correct regex foreslint-plugin/report-message-format(#20300) (루밀LuMir)e251671refactor: extract assertions in RuleTester (#20135) (唯然)2e7f25echore: addlegacy-peer-depsto.npmrc(#20281) (Milos Djermanovic)39c638achore: update eslint-config-eslint dependencies for v10 prereleases (#20278) (Milos Djermanovic)8533b3fchore: update dependency @eslint/json to ^0.14.0 (#20288) (renovate[bot])796ddf6chore: update dependency @eslint/js to ^9.39.1 (#20285) (renovate[bot])v9.39.3Compare Source
Bug Fixes
791bf8dfix: restore TypeScript 4.0 compatibility in types (#20504) (sethamus)Chores
8594a43chore: upgrade @eslint/js@9.39.3 (#20529) (Milos Djermanovic)9ceef92chore: package.json update for @eslint/js release (Jenkins)af498c6chore: ignore/docs/v9.xin link checker (#20453) (Milos Djermanovic)microsoft/playwright (@playwright/browser-chromium)
v1.58.2Compare Source
v1.58.1Compare Source
Highlights
#39036 fix(msedge): fix local network permissions
#39037 chore: update cft download location
#38995 chore(webkit): disable frame sessions on fronzen builds
Browser Versions
v1.58.0Compare Source
web-infra-dev/rspress (@rspress/core)
v2.0.3Compare Source
What's Changed
New Features 🎉
og:descriptionset automatically by @Karibash in #3115Bug Fixes 🐞
Document 📖
Other Changes
de0fac2by @renovate[bot] in #3112New Contributors
Full Changelog: web-infra-dev/rspress@v2.0.2...v2.0.3
actions/checkout (actions/checkout)
v6.0.2Compare Source
actions/setup-node (actions/setup-node)
v6.2.0Compare Source
autofix-ci/action (autofix-ci/action)
v1.3.3: autofix-ci/action 1.3.3Compare Source
What's Changed
.cito.comTLD.This aims to improve overall reliability (#32).
api.autofix.ciwill remain available as an alias for the time being.Full Changelog: autofix-ci/action@v1.3.2...v1.3.3
eslint/eslint (eslint)
v10.0.2Compare Source
v10.0.1Compare Source
Bug Fixes
c87d5bdfix: update eslint (#20531) (renovate[bot])d841001fix: updateminimatchto10.2.1to address security vulnerabilities (#20519) (루밀LuMir)04c2147fix: update error message for unused suppressions (#20496) (fnx)38b089cfix: update dependency @eslint/config-array to ^0.23.1 (#20484) (renovate[bot])Documentation
5b3dbcedocs: add AI acknowledgement section to templates (#20431) (루밀LuMir)6f23076docs: toggle nav in no-JS mode (#20476) (Tanuj Kanti)b69cfb3docs: Update README (GitHub Actions Bot)Chores
e5c281fchore: updates for v9.39.3 release (Jenkins)8c3832achore: update @typescript-eslint/parser to ^8.56.0 (#20514) (Milos Djermanovic)8330d23test: add tests for config-api (#20493) (Milos Djermanovic)37d6e91chore: remove eslint v10 prereleases from eslint-config-eslint deps (#20494) (Milos Djermanovic)da7cd0erefactor: cleanup error message templates (#20479) (Francesco Trotta)84fb885chore: package.json update for @eslint/js release (Jenkins)1f66734chore: addeslinttopeerDependenciesof@eslint/js(#20467) (Milos Djermanovic)v10.0.0Compare Source
v9.39.3Compare Source
Bug Fixes
791bf8dfix: restore TypeScript 4.0 compatibility in types (#20504) (sethamus)Chores
8594a43chore: upgrade @eslint/js@9.39.3 (#20529) (Milos Djermanovic)9ceef92chore: package.json update for @eslint/js release (Jenkins)af498c6chore: ignore/docs/v9.xin link checker (#20453) (Milos Djermanovic)nodejs/node (node)
v24.13.1Compare Source
v24.13.0: 2026-01-13, Version 24.13.0 'Krypton' (LTS), @marco-ippolitoCompare Source
This is a security release.
Notable Changes
lib:
lib,permission:
src:
src,lib:
tls:
Commits
2092785d01] - deps: update c-ares to v1.34.6 (Node.js GitHub Bot) #609973e58b7f2af] - deps: update undici to 7.18.2 (Node.js GitHub Bot) #612834ba536a5a6] - (CVE-2025-59465) lib: add TLSSocket default error handler (RafaelGSS) nodejs-private/node-private#79789adaa21fd] - (CVE-2025-55132) lib: disable futimes when permission model is enabled (RafaelGSS) nodejs-private/node-private#7487302b4dae1] - (CVE-2025-55130) lib,permission: require full read and write to symlink APIs (RafaelGSS) nodejs-private/node-private#760ac030753c4] - (CVE-2025-59466) src: rethrow stack overflow exceptions in async_hooks (Matteo Collina) nodejs-private/node-private#77320075692fe] - (CVE-2025-55131) src,lib: refactor unsafe buffer creation to remove zero-fill toggle (Сковорода Никита Андреевич) nodejs-private/node-private#75920591b0618] - (CVE-2026-21637) tls: route callback exceptions through error handlers (Matteo Collina) nodejs-private/node-private#796Configuration
📅 Schedule: Branch creation - Between 12:00 AM and 03:59 AM, on day 1 of the month ( * 0-3 1 * * ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.
Summary by CodeRabbit
Chores
Bug Fixes
Refactor