-
Notifications
You must be signed in to change notification settings - Fork 14
add some detail about envoy-gateway-operator #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
WalkthroughUpdates the Envoy Gateway Operator and UI installation docs: adds a "How to Add Taint Tolerations to the Operator" subsection with a kubectl patch, adds operator pod status verification, and reorganizes UI installation steps to require switching to the global cluster and installing the GatewayAPI Plugin. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@docs/en/solutions/How_to_Install_EnvoyGatewayOperator_And_UI_Before_ACP_4.2.md`:
- Line 74: The heading "###### How to Check the Operator Status**" has an extra
trailing bold marker; edit the heading text (the line containing "###### How to
Check the Operator Status**") to remove the stray "**" so it becomes "###### How
to Check the Operator Status" (or wrap the entire heading properly with matching
bold/heading markers if intended), ensuring the markdown heading renders
correctly.
docs/en/solutions/How_to_Install_EnvoyGatewayOperator_And_UI_Before_ACP_4.2.md
Outdated
Show resolved
Hide resolved
1ce1616 to
cb8e04f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In
`@docs/en/solutions/How_to_Install_EnvoyGatewayOperator_And_UI_Before_ACP_4.2.md`:
- Around line 58-72: Add a caution and a scoped example around the kubectl patch
that sets tolerations so readers aren’t advised to use the overly-broad
"operator: Exists" alone; update the section that shows the patch (the
tolerations JSON under the patch command) to include a brief warning sentence
and an alternative scoped toleration example using "key" (e.g.,
"node-role.kubernetes.io/control-plane") and "effect" ("NoSchedule") alongside
"operator": "Exists" so the toleration targets specific taints instead of all
taints.
Summary by CodeRabbit