Add multivariate rational interpolation#122
Merged
mohabsafey merged 1 commit intoalgebraic-solving:mainfrom Mar 24, 2026
Merged
Add multivariate rational interpolation#122mohabsafey merged 1 commit intoalgebraic-solving:mainfrom
mohabsafey merged 1 commit intoalgebraic-solving:mainfrom
Conversation
97fee6f to
7725edc
Compare
d107d78 to
3f81a9f
Compare
91bf8eb to
5f89875
Compare
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
+ Coverage 83.02% 83.58% +0.55%
==========================================
Files 25 32 +7
Lines 2610 3173 +563
==========================================
+ Hits 2167 2652 +485
- Misses 443 521 +78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
edcc229 to
7d03628
Compare
Collaborator
|
Many thanks for all of that. This looks really great.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR aimed at adding (multithreaded) multivariate polynomial and rational interpolation schemes to AlgebraicSolving.jl. The implementation follows the description in https://arxiv.org/pdf/1608.01902.
Direct applications of the interpolation schemes include computing
This functionality is included in the PR. The signature matches that of Add resultant/discriminant for QQ/ZZ/FpMPolyRingElem Nemocas/Nemo.jl#2255.
This functionality will be included in an upcoming PR.
For now, the methods are not exposed at top-level; they can be used either with
using AlgebraicSolving.Interpolation, or internally in AlgebraicSolving.jl.