Skip to content

Add multivariate rational interpolation#122

Merged
mohabsafey merged 1 commit intoalgebraic-solving:mainfrom
wegank:cuyt-lee-init
Mar 24, 2026
Merged

Add multivariate rational interpolation#122
mohabsafey merged 1 commit intoalgebraic-solving:mainfrom
wegank:cuyt-lee-init

Conversation

@wegank
Copy link
Copy Markdown
Contributor

@wegank wegank commented Feb 12, 2026

This is a PR aimed at adding (multithreaded) multivariate polynomial and rational interpolation schemes to AlgebraicSolving.jl. The implementation follows the description in https://arxiv.org/pdf/1608.01902.

Direct applications of the interpolation schemes include computing

For now, the methods are not exposed at top-level; they can be used either with using AlgebraicSolving.Interpolation, or internally in AlgebraicSolving.jl.

@wegank wegank force-pushed the cuyt-lee-init branch 2 times, most recently from 97fee6f to 7725edc Compare February 13, 2026 15:23
@wegank wegank force-pushed the cuyt-lee-init branch 7 times, most recently from d107d78 to 3f81a9f Compare March 9, 2026 13:57
@wegank wegank changed the title [WIP] Add multivariate rational interpolation Add multivariate rational interpolation Mar 9, 2026
@wegank wegank marked this pull request as ready for review March 9, 2026 13:57
@wegank wegank force-pushed the cuyt-lee-init branch 4 times, most recently from 91bf8eb to 5f89875 Compare March 9, 2026 16:28
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 9, 2026

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 83.80463% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.58%. Comparing base (374e12d) to head (cb3b4d8).
⚠️ Report is 103 commits behind head on main.

Files with missing lines Patch % Lines
src/progress/main.jl 36.84% 24 Missing ⚠️
src/interp/cuyt_lee.jl 82.81% 22 Missing ⚠️
src/interp/thiele.jl 76.66% 14 Missing ⚠️
src/interp/newton.jl 97.64% 2 Missing ⚠️
src/interp/resultant.jl 98.70% 1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #122      +/-   ##
==========================================
+ Coverage   83.02%   83.58%   +0.55%     
==========================================
  Files          25       32       +7     
  Lines        2610     3173     +563     
==========================================
+ Hits         2167     2652     +485     
- Misses        443      521      +78     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@wegank wegank force-pushed the cuyt-lee-init branch 4 times, most recently from edcc229 to 7d03628 Compare March 10, 2026 13:07
@mohabsafey
Copy link
Copy Markdown
Collaborator

Many thanks for all of that. This looks really great.
Just some first comments:

  • could you check that the implicit assumptions on the input are satisfied (if this is not too costly)?
  • these assumptions should be stated in the documentations of these functions (mainly cuyt_lee, newton, thiele)
  • I think it would be valuable if these documentations include examples of use.

@mohabsafey mohabsafey merged commit 555266c into algebraic-solving:main Mar 24, 2026
8 checks passed
@wegank wegank deleted the cuyt-lee-init branch March 24, 2026 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants