Allow Gröbner basis computation with inputs in msolve format#127
Merged
ederc merged 1 commit intoalgebraic-solving:mainfrom Mar 19, 2026
Merged
Allow Gröbner basis computation with inputs in msolve format#127ederc merged 1 commit intoalgebraic-solving:mainfrom
ederc merged 1 commit intoalgebraic-solving:mainfrom
Conversation
wegank
force-pushed
the
gb-array-init
branch
2 times, most recently
from
a48ee40 to
22c6c19
Compare
wegank
changed the title
Collaborator
|
Maybe you could add a test, otherwise it's fine for me. |
Contributor
Author
|
I've added two tests in test/algorithms/groebner-bases.jl. |
Collaborator
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
_core_groebner_basis_arrayto allow Gröbner basis computation with inputs in msolve format rather than of AbstractAlgebra.jl types. Since the msolve format relies exclusively on built-in types of Julia, the resulting data can be passed easily between processes.