Fix for cross compiling for android#291
Open
talregev wants to merge 1 commit intoalgebraic-solving:masterfrom
Open
Fix for cross compiling for android#291talregev wants to merge 1 commit intoalgebraic-solving:masterfrom
talregev wants to merge 1 commit intoalgebraic-solving:masterfrom
Conversation
13 tasks
dg0yt
reviewed
Mar 12, 2026
| AC_FUNC_MALLOC | ||
| AC_FUNC_REALLOC | ||
| AC_CHECK_FUNCS([floor getdelim gettimeofday memmove memset pow sqrt strchr strstr strtol]) | ||
| AC_CHECK_FUNCS([floor getdelim gettimeofday memmove memset malloc realloc pow sqrt strchr strstr strtol]) |
There was a problem hiding this comment.
Note that this changes the meanging of the result macros. The change is valid if msolve only depends on the availability of the functions, not on being "compatible with the GNU C library" malloc/realloc at runtime.
Author
There was a problem hiding this comment.
Do you have a better solution?
Contributor
There was a problem hiding this comment.
msolve depends heavily on malloc/realloc, so this should not be a problem.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for cross compiling for android