Fix real root isolation when sizeof(long)==4#292
Merged
mohabsafey merged 1 commit intoalgebraic-solving:masterfrom Mar 12, 2026
Merged
Fix real root isolation when sizeof(long)==4#292mohabsafey merged 1 commit intoalgebraic-solving:masterfrom
mohabsafey merged 1 commit intoalgebraic-solving:masterfrom
Conversation
Contributor
|
This one also looks good to me |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As
mpz_get_uireturns a value of typeunsigned long int, the following linemsolve/src/usolve/refine.c
Line 58 in a38798c
is only sound when
sizeof(unsigned long int) == sizeof(long long int)holds. This PR fixes the cases where the identity is not satisfied.Tested on 32-bit Linux in combination with #282.