Fix macOS MPS compatibility and bump version to 0.3.13 #294
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add PYTORCH_ENABLE_MPS_FALLBACK=1 environment variable when starting test servers to allow PyTorch operations to fall back to CPU when MPS (Metal Performance Shaders) doesn't support them. This fixes test failures on macOS with Apple Silicon where operations like aten::linalg_cholesky_ex.L are not implemented for MPS device.
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
PYTORCH_ENABLE_MPS_FALLBACK=1environment variableDetails
Tests were failing on macOS with Apple Silicon because PyTorch operations like
aten::linalg_cholesky_ex.Lare not implemented for MPS device. The fix enables CPU fallback for unsupported operations.Test plan
test_conversation_logging_server.pypasses on macOStest_n_parameter.pypasses on macOS🤖 Generated with Claude Code