fix(k8s): reject unsupported image.auth with actionable error#364
Merged
Pangjiping merged 1 commit intoalibaba:mainfrom Mar 6, 2026
Merged
Conversation
liuxiaopai-ai
requested review from
Generalwin,
Pangjiping,
hittyt and
jwx0925
as code owners
Collaborator
|
Thanks for this fix. 😊 |
Generalwin
approved these changes
Mar 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
image.auth400 INVALID_PARAMETERwith actionable guidance to useimagePullSecretsWhy
Issue #328 shows user confusion when private images fail in K8s mode. Today
image.authis silently ignored in K8s runtime, which leads to late timeout errors and poor debuggability. Failing fast with a clear message prevents misconfiguration.Testing
pytest -q server/tests/k8s/test_kubernetes_service.pyRefs #328