Skip to content

feature: add metric exporter interface#3416

Open
Daydreamer-ia wants to merge 3 commits intoalibaba:1.8from
Daydreamer-ia:1.8
Open

feature: add metric exporter interface#3416
Daydreamer-ia wants to merge 3 commits intoalibaba:1.8from
Daydreamer-ia:1.8

Conversation

@Daydreamer-ia
Copy link
Copy Markdown

@Daydreamer-ia Daydreamer-ia commented Jun 9, 2024

Describe what this PR does / why we need it

#3314

Does this pull request fix one issue?

Describe how you did it

Describe how to verify it

Special notes for reviews

@Daydreamer-ia Daydreamer-ia mentioned this pull request Jun 9, 2024
Closed
@LearningGp LearningGp added to-review To review area/metrics Issues or PRs related to metrics and monitoring kind/feature Category issues or prs related to feature request. labels Aug 16, 2024
LearningGp
LearningGp requested changes Aug 23, 2024
View reviewed changes
Comment thread sentinel-core/src/main/java/com/alibaba/csp/sentinel/node/metric/MetricTimerListener.java Outdated
Comment thread sentinel-core/src/main/java/com/alibaba/csp/sentinel/node/metric/export/DefaultExporter.java Outdated
Comment thread sentinel-core/src/main/java/com/alibaba/csp/sentinel/node/metric/MetricTimerListener.java
@LearningGp
Copy link
Copy Markdown
Collaborator

LearningGp commented Aug 23, 2024

We may need to discuss whether we should support having multiple exporters active at the same time. I'm not sure about your perspective on this.

@Daydreamer-ia
Copy link
Copy Markdown
Author

Daydreamer-ia commented Sep 25, 2024

We may need to discuss whether we should support having multiple exporters active at the same time. I'm not sure about your perspective on this.

I keep one leave is order to sync the old logic, to be honest, i agree with you that support multiple exporters here. Do i keep more exporters active this pr?

LearningGp
LearningGp requested changes Sep 17, 2025
View reviewed changes
Comment thread .../test/resources/META-INF/services/com.alibaba.csp.sentinel.node.metric.export.MetricExporter
Copy link
Copy Markdown
Collaborator

@LearningGp LearningGp Sep 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file does not require a LICENSE.

@LearningGp
Copy link
Copy Markdown
Collaborator

LearningGp commented Sep 17, 2025

We may need to discuss whether we should support having multiple exporters active at the same time. I'm not sure about your perspective on this.

I keep one leave is order to sync the old logic, to be honest, i agree with you that support multiple exporters here. Do i keep more exporters active this pr?

For this PR, let's keep the single export implementation as is.

@LearningGp LearningGp added wait-for-response PRs that require further response and removed to-review To review labels Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LearningGp LearningGp LearningGp requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

area/metrics Issues or PRs related to metrics and monitoring kind/feature Category issues or prs related to feature request. wait-for-response PRs that require further response

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Daydreamer-ia @LearningGp