RN .40 compatibility (tweak #import statements)#202
Open
lefnire wants to merge 1 commit intoalinz:masterfrom
Open
RN .40 compatibility (tweak #import statements)#202lefnire wants to merge 1 commit intoalinz:masterfrom
lefnire wants to merge 1 commit intoalinz:masterfrom
Conversation
|
I have verified the changes and they work for me. Please merge. Note that it breaks the package for people still on 0.39 so it should be mentioned in the readme that anybody on 0.39 or earlier should use the previous version of this package. |
|
This works for me too. |
Author
|
Don't think so. The functionality was merged into RN core, but with issues.
Bit of an awkward handoff period
…On Jan 25, 2017 6:03 PM, "Zino Hofmann" ***@***.***> wrote:
Btw is the repo still maintained?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#202 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAL6gsMHZsvAzv3Re2FEcMNIybAJonU2ks5rV9SqgaJpZM4LesED>
.
|
Contributor
That's putting it mildly. The RN devs are too ivory tower, so instead of something functional, it's a half finished thing that's useless to me as it breaks on 3rd party web apps. With all the PRs sitting backlogged on |
|
Should be merged! 👍 |
xuanheScript
approved these changes
Mar 6, 2017
|
I also sent a close one: #217 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please do take a careful look, I'm not an Obj-C dev. Just following the example of other projects' .39->.40 PRs. Tested in Simulator and all seems well. Compilation fails in RN .40 w/o these changes.