amixer: support infinite line length for --stdin option and add --file option#321
Open
flamesky0 wants to merge 2 commits intoalsa-project:masterfrom
Open
amixer: support infinite line length for --stdin option and add --file option#321flamesky0 wants to merge 2 commits intoalsa-project:masterfrom
flamesky0 wants to merge 2 commits intoalsa-project:masterfrom
Conversation
added 2 commits
January 29, 2026 01:08
Signed-off-by: Mikhail Ivashinenko <miuivashinenko@salutedevices.com>
Allows to read commands directly from file. Refactor exec_stdin() to exec_file() function to support generic files. Signed-off-by: Mikhail Ivashinenko <miuivashinenko@salutedevices.com>
flamesky0
force-pushed
the
amixer_stdin_file
branch
from
8132bd2 to
dcb8131
Compare
flamesky0
changed the title
Author
|
seems like it's better to get rid of constraint of 256 bytes for filename for --file option using strndup(optarg, PATH_MAX). If you approve idea in general, i'm willing to do it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is a problem with limited buffer size for option --stdin 256 bytes. It can be eliminated by making use of getline() function. Furthermore, it's possible to refactor exec_stdin() function to support reading from any file and support --file option. Would be very convenient for any devices with complex audio architecture to speedup boot-up initialization.