plugin_convention_warnings.py script#178
Merged
alexandraBara merged 6 commits intodevelopmentfrom Apr 8, 2026
Merged
Conversation
added 3 commits
March 30, 2026 16:29
- scripts/plugin_convention_warnings.py: AST checks for CMD_/Field conventions - .pre-commit-config.yaml: local hook (always_run, exits 0) Made-with: Cursor
alexandraBara
requested changes
Apr 7, 2026
| return False | ||
|
|
||
|
|
||
| def _check_cmd_prefixes(path: Path, tree: ast.Module) -> list[str]: |
Collaborator
There was a problem hiding this comment.
Add a docstring here and comment on how the collector CMD_<> should look like. Its easier to read that than try and interpret this code. Users should be able to read the comments in this script and figure out what the rules are. Maybe add a module level docstring and details every rule there. Then reference the item number in the docstring of the function. Something like this:
module docstring:
Rules to follow:
1. Every collector command needs to be added like: CMD_<> or CMD
2. ...
Then in the function that checks the rule add the docstring like:
Implement rule #2. Check that collector cmd variable is of format: CMD_<>
alexandraBara
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this script runs as a part of pre commit check to ensure :