Conversation
| class AmdSmiAnalysisRef(BaseModel): | ||
| """Collector-filled summary for reference config""" | ||
|
|
||
| model_config = ConfigDict(extra="forbid") |
There was a problem hiding this comment.
dont think this is needed
| return None | ||
|
|
||
|
|
||
| _PLDM_FW_ID = "PLDM_BUNDLE" |
There was a problem hiding this comment.
@graepaul is this something we can move into an analyzer_arg? will this value ever change?
There was a problem hiding this comment.
I would use {fw_id: fw_verrsion} map as an analyzer arg to provide more flexibility to the users
The users should then provide a dict where the keys are fw_ids and the values are the fw_version
graepaul
left a comment
graepaul
left a comment
There was a problem hiding this comment.
I like having XGMI Speed optional, see comments on the rest of the changes.
| _PLDM_FW_ID = "PLDM_BUNDLE" | ||
|
|
||
|
|
||
| def build_amd_smi_analysis_ref( |
There was a problem hiding this comment.
This would make more sense as a method in the AmdSmiDataModel
| return None | ||
|
|
||
|
|
||
| _PLDM_FW_ID = "PLDM_BUNDLE" |
There was a problem hiding this comment.
I would use {fw_id: fw_verrsion} map as an analyzer arg to provide more flexibility to the users
The users should then provide a dict where the keys are fw_ids and the values are the fw_version
| gpu_processes_max: Optional[int] = None | ||
| if process: | ||
| counts: list[int] = [] | ||
| for proc in process: | ||
| if not proc.process_list: | ||
| continue | ||
| if isinstance(proc.process_list[0].process_info, str): | ||
| continue | ||
| counts.append(len(proc.process_list)) | ||
| if counts: | ||
| gpu_processes_max = max(counts) |
There was a problem hiding this comment.
Could these just be independent properties in the AmdSmiDataModel
3 participants
fixed:
a. AmdSmi should not fail when expected xgmi_speed is not give. It should give a warning that expected value is not set and analysis is skipped.
b. AmdSmiPlugin: ('Setting analyzer args from datamodel is not implemented for class: %s', 'AmdSmiAnalyzerArgs')
Update : implemented arg --expected-firmware-versions to give flexibility to user to check for desrired fw
node-scraper run-plugins AmdSmiPlugin --expected-firmware-versions '{"PLDM_BUNDLE":"00.26.00.02"}'or