Skip to content

Fix ruby 2.7 deprecation warning in login.rb#25

Closed
mfittko wants to merge 1 commit intoamzn:masterfrom
mfittko:fix-ruby-2-7-deprecation-warning
Closed

Fix ruby 2.7 deprecation warning in login.rb#25
mfittko wants to merge 1 commit intoamzn:masterfrom
mfittko:fix-ruby-2-7-deprecation-warning

Conversation

@mfittko
Copy link
Copy Markdown

@mfittko mfittko commented Jan 31, 2022

Issue #, if available:

Description of changes:

Replace deprecated URI#unescape method call with call on URI::DEFAULT_PARSER#unescape

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@mfittko
Copy link
Copy Markdown
Author

mfittko commented Jan 31, 2022

I ran the tests by manually installing the gem dependencies (no Rakefile here) and executing ruby -Ilib:test test/amazon_pay_unit_test.rb.
Unfortunately, login.rb is uncovered, but changes do work fine for me.

@mfittko
Copy link
Copy Markdown
Author

mfittko commented Jan 31, 2022

changelog missing

@mfittko
Copy link
Copy Markdown
Author

mfittko commented Jan 4, 2023

superseded by #28

@mfittko mfittko closed this Jan 4, 2023
@mfittko mfittko deleted the fix-ruby-2-7-deprecation-warning branch January 4, 2023 20:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant