feat: add session token authentication (MB_SESSION_TOKEN)#8
Open
filippomortari wants to merge 4 commits intoandreagrandi:masterfrom
Open
feat: add session token authentication (MB_SESSION_TOKEN)#8filippomortari wants to merge 4 commits intoandreagrandi:masterfrom
filippomortari wants to merge 4 commits intoandreagrandi:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MB_SESSION_TOKENas an alternative authentication method alongside the existingMB_API_KEYmetabase.SESSION)MB_API_KEYandMB_SESSION_TOKENare mutually exclusive; setting both is a config errorChanges
internal/config/config.go— AcceptMB_SESSION_TOKENenv var, validate mutual exclusion withMB_API_KEYinternal/client/client.go— SendX-Metabase-Sessionheader when session token is configuredtests/config_test.go— Tests for session-only, neither auth, and both-auth-error casestests/client_test.go— Tests for session token header setting across GET/POST requestsREADME.md— Document both authentication optionsTest plan
go test ./tests/)