feat(@schematics/angular): add prettier dependency by default with --skip-prettier flag added to skip prettier install#32260
Closed
mistrykaran91 wants to merge 1 commit intoangular:mainfrom
Conversation
…skip-prettier flag added to skip prettier install Add prettier as a devDependency by default when creating a new workspace since the prettier configuration is already being added to package.json. Users can opt-out using the --skip-prettier flag which will skip both the prettier configuration and dependency. Fixes angular#32216
angular-robot
bot
added
detected: feature
alan-agius4
added
the
needs: discussion
alan-agius4
removed
the
needs: discussion
Collaborator
|
Hi @mistrykaran91, thanks for your contribution however we decided to go with a slightly different approach #32365 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add prettier as a devDependency by default when creating a new workspace since the prettier configuration is already being added to package.json.
Users can opt-out using the --skip-prettier flag which will skip both the prettier configuration and dependency.
PR Checklist
Please check to confirm your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Currently, prettier configuration are added but prettier is not installed.
Issue Number: #32216
What is the new behavior?
Prettier will be installed by default and --skip-prettier flag will skip installation and adding the configuration
Does this PR introduce a breaking change?
Other information