Fix(WhiteBoard): Prevent Integer display wrapping#20333
Merged
BrayanDSO merged 1 commit intoankidroid:mainfrom Feb 19, 2026
Merged
Fix(WhiteBoard): Prevent Integer display wrapping#20333BrayanDSO merged 1 commit intoankidroid:mainfrom
BrayanDSO merged 1 commit intoankidroid:mainfrom
Conversation
Contributor
Author
|
While checking the app through Google Accessibility Scanner, it did flag some other issues with the whiteboard, is it cool if i work on those too? |
Contributor
|
feel like the commit message could be shortened, and the rest could be moved into the description |
BrayanDSO
approved these changes
Feb 18, 2026
lukstbit
approved these changes
Feb 19, 2026
Contributor
Author
|
Yeah sure I'll squash the commits into one |
eafc7e7 to
9765a25
Compare
Contributor
Author
|
Alright done |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose / Description
#20332 When Android Device Font Size is set to Largest with Default View, Eraser Size Integer wraps at 3 digit numbers
Fixes
Fixes #20332
Approach
This approach negates the clipping from the static width of 48dp from minTouchTargetSize and allows for wrapping in case of large fonts, and sets minWidth to minTouchTargetSize to meet Accessibility Criteria
How Has This Been Tested?
This has been tested on a local Android Device of 17.06cm display, width accessibility has been confirmed using Layout Inspector in Android Studio
Learning (optional, can help others)
While considering small texts, setting static widths may cause issues with large default fonts in Accessibility
Links to blog posts, patterns, libraries or addons used to solve this problem
N/A
Checklist
Please, go through these checks before submitting the PR.