fix(cli): remove stray dot from --help logo#17170
Open
mynameistito wants to merge 26 commits intoanomalyco:devfrom
Open
fix(cli): remove stray dot from --help logo#17170mynameistito wants to merge 26 commits intoanomalyco:devfrom
mynameistito wants to merge 26 commits intoanomalyco:devfrom
Conversation
github-actions
bot
added
contributor
needs:compliance
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
github-actions
bot
removed
needs:issue
needs:compliance
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
|
Isn't it actually the top block of the character 'd' ? It's opencooe now. |
Contributor
Author
Hmm true! I didn't even realise that lmao fixed now |
mynameistito
force-pushed
the
fix/help-logo-white-dot
branch
from
bef9f54 to
a29a469
Compare
mynameistito
force-pushed
the
fix/help-logo-white-dot
branch
from
a29a469 to
6182159
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #17171 #11278
Type of change
What does this PR do?
The logo in
opencode --helpwas broken because yargs'.usage()strips leading whitespace, collapsing the first row and misplacing the▄(the 'd' bump).Two changes in
ui.ts:\u00A0) instead of regular spaces indraw()so yargs can't collapse themleft.fg(an ANSI escape) so yargs sees it as non-whitespaceNo changes to
logo.tsorlogo.tsx. Follows the single source of truth established in #10912.How did you verify your code works?
Ran
bun run src/index.ts --helpandbun run src/index.ts upgradefrompackages/opencode— both render correctly.Screenshots / recordings
Before:
After:
Checklist