Skip to content

refactor: update server URL to handle ipv6#18067

Open
brenoepics wants to merge 4 commits intoanomalyco:devfrom
brenoepics:fix-ipv6
Open

refactor: update server URL to handle ipv6#18067
brenoepics wants to merge 4 commits intoanomalyco:devfrom
brenoepics:fix-ipv6

Conversation

@brenoepics
Copy link

Issue for this PR

Closes #18059

Type of change

  • Bug fix
  • New feature
  • Refactor / code improvement
  • Documentation

What does this PR do?

This PR fixes the ipv6 handling that got broken somewhere during the past 2 weeks, I noticed it after trying to update my production server that uses ipv6, the PR also introduces a new test case to ensure that "127.0.0.1", "0.0.0.0", "localhost", "::", "::1", "[::]", "[::1]" are working for future versions so we don't have this regression again.

Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR.

If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!

The issue is quite simple: when you are deploying opencode as a coding agent at a cloud network that uses ipv6 (specially for private network traffic), we used to use :: since 0.0.0.0 is ipv4 only, after some change during the past 2 weeks, we started to have a crash on startup: "http://:::4096" cannot be parsed as a URL, yet, 2 weeks ago we had opencode server listening on http://:::4096, I have changed the way we parse the --hostname to ensure we catch ipv6 links and correctly listen fixing it.

How did you verify your code works?

I have run bun dev serve --hostname ::, bun test and I am also using this small patch on my private network while we wait for a next release.

Screenshots / recordings

If this is a UI change, please include a screenshot or recording.

Checklist

  • I have tested my changes locally
  • I have not included unrelated changes in this PR

If you do not follow this template your PR will be automatically rejected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

IPV6 server mode got broken

1 participant