refactor: update server URL to handle ipv6#18067
Open
brenoepics wants to merge 4 commits intoanomalyco:devfrom
Open
refactor: update server URL to handle ipv6#18067brenoepics wants to merge 4 commits intoanomalyco:devfrom
brenoepics wants to merge 4 commits intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #18059
Type of change
What does this PR do?
This PR fixes the ipv6 handling that got broken somewhere during the past 2 weeks, I noticed it after trying to update my production server that uses ipv6, the PR also introduces a new test case to ensure that
"127.0.0.1", "0.0.0.0", "localhost", "::", "::1", "[::]", "[::1]"are working for future versions so we don't have this regression again.Please provide a description of the issue, the changes you made to fix it, and why they work. It is expected that you understand why your changes work and if you do not understand why at least say as much so a maintainer knows how much to value the PR.
If you paste a large clearly AI generated description here your PR may be IGNORED or CLOSED!
The issue is quite simple: when you are deploying opencode as a coding agent at a cloud network that uses ipv6 (specially for private network traffic), we used to use
::since0.0.0.0is ipv4 only, after some change during the past 2 weeks, we started to have a crash on startup:"http://:::4096" cannot be parsed as a URL, yet, 2 weeks ago we hadopencode server listening on http://:::4096, I have changed the way we parse the --hostname to ensure we catch ipv6 links and correctly listen fixing it.How did you verify your code works?
I have run
bun dev serve --hostname ::,bun testand I am also using this small patch on my private network while we wait for a next release.Screenshots / recordings
If this is a UI change, please include a screenshot or recording.
Checklist
If you do not follow this template your PR will be automatically rejected.