feat(app): add GitHub Desktop to open menu#18114
Open
anduimagui wants to merge 5 commits intoanomalyco:devfrom
Open
feat(app): add GitHub Desktop to open menu#18114anduimagui wants to merge 5 commits intoanomalyco:devfrom
anduimagui wants to merge 5 commits intoanomalyco:devfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #
Type of change
What does this PR do?
Adds GitHub Desktop to the desktop app's Open in menu, including the app label and icon. It also makes macOS detection and launching work for GitHub Desktop by handling both the spaced app name used by
open -aand common lookup variants used during app existence checks.How did you verify your code works?
Tested locally on macOS in the desktop app by confirming GitHub Desktop appears in the Open in menu and opens the current project. Also ran
cargo checkinpackages/desktop/src-tauri.Screenshots / recordings
N/A
Checklist