fix(console): add error handling for JSON.parse in benchmarks#18116
Open
tang-vu wants to merge 2 commits intoanomalyco:devfrom
Open
fix(console): add error handling for JSON.parse in benchmarks#18116tang-vu wants to merge 2 commits intoanomalyco:devfrom
tang-vu wants to merge 2 commits intoanomalyco:devfrom
Conversation
`JSON.parse(row.result)` is called without a try-catch block. If the database contains invalid JSON in this column, it will throw an exception and crash the `getBenchmarks` function, breaking the page. Affected files: index.tsx
Contributor
|
Hey! Your PR title Please update it to start with one of:
Where See CONTRIBUTING.md for details. |
…ing-for-json-parse
Contributor
|
Thanks for your contribution! This PR doesn't have a linked issue. All PRs must reference an existing issue. Please:
See CONTRIBUTING.md for details. |
Contributor
|
Thanks for updating your PR! It now meets our contributing guidelines. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue for this PR
Closes #18122
Type of change
What does this PR do?
JSON.parse(row.result)inpackages/console/app/src/routes/bench/index.tsxis called without a try-catch block. If the database contains invalid or corrupt JSON in theresultcolumn, this will throw an unhandled exception and crash thegetBenchmarksfunction, breaking the benchmarks page entirely.The fix:
JSON.parsecall in a try-catch blockSeverity: medium
How did you verify your code works?
Screenshots / recordings
No UI changes - this is a defensive code quality fix.
Checklist
About this PR
This pull request was generated by ContribAI, an AI agent that helps improve open source projects. The change was:
If you have questions or feedback about this PR, please comment below.